Open
Conversation
|
Hi, is there any chance to see this PR merged ? We are waiting for pg 11 support, and to be honest not confindent on a PR owned by a ghost ;-) |
|
Josh Holbrook seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a quick spike thinking this would be easy 🙄
The sticking point is that pg's 11 and 12 by default give ownership of
pg_replication_originandsql_languagestotest_user. pgbedrock itself should be able to work against postgres 11 and 12 as-is, but updating the tests to have the correct initial state is a bit of a chore.One idea is to add "except" support to ownership as well as schemas/tables - this would make the changes less verbose than trying to enumerate all the stuff in
information_schema. For schemas/tables, we depend on the fact that we can scope tables under "read" and "write" which gives us a way to add "except" to the mix. We don't have this convenient "in" for ownership. We bounced around the idea of extending the DSL to allow a dict in addition to a string name / glob.Unfortunately, I gotta drop this, but I wanted to push what I had to give anyone interested in this a starting point to jump from.