Open
Conversation
Seems to be working well with 1.3.1
|
Based on #9, I think you also need to update Source/zzVersionChecker.cs line 68 so KSP-AVC doesn't raise spurious warnings. Also, does this version work on both 1.3.0 and 1.3.1? It might be nice to mark it that way with KSP_VERSION_MIN and KSP_VERSION_MAX. |
Multi-version compatibilty with 1.3.0 - 1.3.1
Tidal-Stream
added a commit
to Tidal-Stream/ProceduralParts
that referenced
this pull request
Dec 24, 2017
Bump mod version to 1.2.13 and tag as compatible with KSP 1.3.1. Remove Module Manager dll. We depend on it being installed so we do not need to ship it. Especially with CKAN this is a cleaner approach. Remove ProceduralParts.dll. This is an output file and should be included in releases, not in the source repository. Last commits did not update this file and if you cloned the master branch thinking this dll would be newer than the release, you would be wrong. Therefore better to separate sources and build files. Copy the README to the root directory so that the github page would have a description. Credits to cmheisel and HebaruSan for their commits in Starwaster#22 Squashed them and added further changes to rebuild it for KSP 1.3.1. Note - some paths were hardcoded, which made the rebuild cumbersome. We should look into how to make the solution file (.sln) portable, for example using environmental variables.
|
Starwaster has not merged this yet and it seems like @cmheisel has not rebuild it, so I forked the repo, squashed these commits, made some other changes, and rebuild it for KSP 1.3.1. I launched a vessel with procedural tanks and it seems to work fine. Here is the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been playing on a 1.3.1 install for several days and everything appears to be working.