feat: implement comprehensive deadline enforcement for escrows#121
Merged
Cedarich merged 8 commits intoStayLitCodes:mainfrom Feb 26, 2026
Merged
feat: implement comprehensive deadline enforcement for escrows#121Cedarich merged 8 commits intoStayLitCodes:mainfrom
Cedarich merged 8 commits intoStayLitCodes:mainfrom
Conversation
- Add EXPIRED status as terminal state - Create expire endpoint for depositors and arbitrators - Update state machine to support expiration transitions - Add guards preventing operations on expired escrows - Update scheduler to auto-expire overdue escrows - Add comprehensive test coverage (13 new tests) - Include full documentation and usage examples Closes deadline enforcement requirements: - Explicit lifecycle rules with EXPIRED state - Deadline-based behaviors using current time - Authorization for depositor and arbitrator - Automatic expiration via scheduler - Event logging and webhook dispatch - Invariants enforced (no ops after expiry) - Full test coverage for all scenarios
Contributor
Author
|
@Cedarich pls review |
Contributor
|
Kindly resolve conflicts and fix build errors |
Contributor
Author
|
@Cedarich it's done |
Contributor
|
Kindly address lint errors |
- Fix missing closing parenthesis in logEvent call - Replace 'as any' with proper 'as UpdateResult' type casting - Ensure TypeScript type safety in test mocks
Contributor
Author
|
@Cedarich That's done |
Contributor
|
Please address lint error |
- Remove extra closing parenthesis on line 307 - Fix syntax error in expire method
Contributor
|
There’s conflict |
Contributor
Author
|
@Cedarich it should be done now |
Contributor
|
Please Run npm run lint and fix lint errors |
Contributor
Author
|
@Cedarich just found out there was an old duplicated file causing the problem so i remove it |
Contributor
|
Please address lint |
Contributor
|
please resolve conflicts let merge. |
Contributor
Author
|
i've resolved it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes deadline enforcement requirements:
closes #94