Skip to content

fix[#91]: resolve failing test by initializing operator before pause#126

Merged
Cedarich merged 12 commits intoStayLitCodes:mainfrom
AbuJulaybeeb:feat/issue-91-role-based-admin
Feb 28, 2026
Merged

fix[#91]: resolve failing test by initializing operator before pause#126
Cedarich merged 12 commits intoStayLitCodes:mainfrom
AbuJulaybeeb:feat/issue-91-role-based-admin

Conversation

@AbuJulaybeeb
Copy link
Contributor

@AbuJulaybeeb AbuJulaybeeb commented Feb 25, 2026

Closes #91

Summary of Changes:

  • Updated VaultixEscrow initialization to accept separate operator and arbitrator roles alongside admin.
  • Refactored set_paused and update_fee to strictly require operator authorization.
  • Refactored resolve_dispute to strictly require arbitrator authorization.
  • Added specific errors: OperatorNotInitialized and ArbitratorNotInitialized.
  • Updated test suite to reflect new initialization signatures and added negative tests for role isolation. All 26 tests passing.

Cli issue fixed

@Cedarich
Copy link
Contributor

Please resolve conflicts

@Cedarich
Copy link
Contributor

Please fix failing workflow

@AbuJulaybeeb
Copy link
Contributor Author

done

Copy link
Contributor Author

@AbuJulaybeeb AbuJulaybeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check sir, the error was from the previous person whom commited

@AbuJulaybeeb AbuJulaybeeb force-pushed the feat/issue-91-role-based-admin branch from 45b27fc to 6749e53 Compare February 26, 2026 14:16
@AbuJulaybeeb AbuJulaybeeb force-pushed the feat/issue-91-role-based-admin branch from 743f9a5 to d5a36e7 Compare February 27, 2026 12:36
@AbuJulaybeeb AbuJulaybeeb force-pushed the feat/issue-91-role-based-admin branch from c921a9e to a161068 Compare February 27, 2026 13:23
Copy link
Contributor

@Cedarich Cedarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo changes from contract.yml file

@Cedarich
Copy link
Contributor

@AbuJulaybeeb i can still changes undo and commit

@AbuJulaybeeb
Copy link
Contributor Author

AbuJulaybeeb commented Feb 28, 2026 via email

@AbuJulaybeeb
Copy link
Contributor Author

done sir
changes from contract.yml undone

Copy link
Contributor

@Cedarich Cedarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you just commit the files you modified only, I noticed you are pushing 520 files

…es#91) updated onchain/src/lib.rs and onchain/src/test.rs
@AbuJulaybeeb
Copy link
Contributor Author

done

@Cedarich Cedarich merged commit d967280 into StayLitCodes:main Feb 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contract-Level Role-Based Admin & Governance

2 participants