feat: Implemented Configurable Fee Model (Per-Escrow & Token-Specific Fees) to close #93#130
Merged
Cedarich merged 4 commits intoStayLitCodes:mainfrom Mar 3, 2026
Conversation
Contributor
Author
|
@Cedarich please, review. |
Contributor
|
Please check formatting errors |
Contributor
Author
|
@Cedarich merge conflicts resolved and fmt errors. Please, review. And I observe you people commited |
Contributor
Author
|
@Cedarich please, review. Clippy errors resolved. |
Contributor
|
@Oluwaseyi89 Boss please fix failing test |
Contributor
Author
|
@Cedarich bugs causing panic fixed and all tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a configurable fee model that extends the current flat fee structure to support per-token and per-escrow fee overrides, providing greater flexibility for different assets and use cases.
Key Features
token_fee_bpsmappingescrow_fee_bpsmappingNew Admin Functions
set_token_fee(env, token_address, fee_bps)- configure token-specific feesset_escrow_fee(env, escrow_id, fee_bps)- configure escrow-specific feesEvents
FeeUpdated(scope, key, old_fee, new_fee)emitted for all fee changesTesting
Closes #93