Skip to content

Conversation

@bepisfever
Copy link
Contributor

@bepisfever bepisfever commented Aug 10, 2025

Adding 2 global variables that can be changed to modify interest more easily without modifying the behavior of vanilla interest-related variables.

  • G.GAME.extra_interest_cap: Adds onto the current interest cap.
  • G.GAME.extra_per_interest: Adds onto the amount of money per $1 interest.

SMODS.get_interest() is added, which returns the total interest cap, and total cash per interest.

And Jokers can now have calc_interest(card):

  • Returning add_cap will increase interest cap by that amount.
  • Returning add_per_interest will increase cash per interest by that amount.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

@bepisfever bepisfever changed the title Patch 7 Changes to interest Aug 10, 2025
@bepisfever bepisfever changed the title Changes to interest calc_interest, and variables to better modify interest Aug 10, 2025
@english5040
Copy link
Collaborator

Very reasonable, making interest easy to modify is a good idea. I remember the getter contexts thing; that seems applicable to this, you may need to update this PR.

About API structure: I am concerned about Card:calculate_interest(), because you're adding on another function onto every card. It feels a bit unnatural.

@english5040 english5040 requested a review from Eremel as a code owner October 7, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants