feat(explain): enrich transaction explanations with ledger timeline context#144
Merged
Tinna23 merged 1 commit intoStellarCommons:mainfrom Feb 26, 2026
Conversation
Tinna23
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #86, adding crucial temporal context to transaction explanations. Previously, users had no way of knowing when a transaction occurred or which ledger it was bundled into. By parsing and exposing the ledger close time and sequence number, explanations are now significantly richer and more practical for timeline debugging.
Changes Made
src/services/horizon.rs:created_at(Option<String>) andledger_sequence(Option<u32>) to the Horizon deserialization models.src/explain/transaction.rs:ledger_closed_atandledgerto theTransactionExplanationstruct.format_ledger_time(iso_string: &str) -> Stringutility function to handle UTC display formatting.'This transaction was confirmed on {date} at {time} UTC (ledger #{sequence})'.Acceptance Criteria Met
TransactionExplanationincludesledger_closed_atandledgerfieldsTest Coverage
All tests passing (150+ suite). Added specific coverage for
format_ledger_time:test_format_ledger_time_date_onlytest_format_ledger_time_empty_stringtest_format_ledger_time_end_of_daytest_format_ledger_time_invalid_returns_originaltest_format_ledger_time_midnighttest_format_ledger_time_standard_utctest_format_ledger_time_strips_secondstest_format_ledger_time_with_positive_offsettest_format_ledger_time_with_whitespaceDependencies
Depends on #4, #111
Linked Issues
Closes #86