fix: resolve issues with self parameter in FeeRepository methods and improve webhook delivery handling#65
Merged
Tinna23 merged 1 commit intoStellarCommons:mainfrom Mar 6, 2026
Conversation
…improve webhook delivery handling - Fixed incorrect usage of `self` parameter in multiple methods of `FeeRepository`. - Updated webhook delivery handling in `AlertManager` to prevent value moves in async tasks. - Changed conversion of response body bytes to use `to_vec()` for compatibility. - Added missing methods in `FeeRepository` to ensure proper functionality. - Created new database file `stellar_fees.db` for tracking fees. - Added test results file for integration tests.
Tinna23
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selfparameter in multiple methods ofFeeRepository.AlertManagerto prevent value moves in async tasks.to_vec()for compatibility.FeeRepositoryto ensure proper functionality.stellar_fees.dbfor tracking fees.