Draft
Conversation
Unfortunately, Apple decided to make use of port 5000 on the AirPlay... OMG 🤦🏾
BREAKING CHANGE: we will focus on Deno from now on
Also migrate the node path import
Vitest is given issues running with Deno, it can't resolve some import paths; seems like it uses Node behind the scenes which breaks everything.
The only BrowserFingerprint only works with Node, we had to implement our own for Deno
b4566b4 to
45e7281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are changing the code base to be supported by Deno.
This decision is based on the willing to use TypeScript without any compilation step and run any type of script out of the box. Also, we prefer Deno's API, which is modern and faster compared to Node.