Skip to content

Conversation

@kysolvik
Copy link
Collaborator

@kysolvik kysolvik commented May 2, 2025

Solves #51

  • Removed predict() method from reservoir computing model to avoid confusion with forecast()
  • Renamed generate() to readin() to avoid confusion with data generators. This method applies Win to an input signal time series to produce reservoir state time series. Open to other names, let me know what you think.
  • Related to rc model DA, updated ETKF and Var3D da cyclers to match input xarray variable names when producing analysis. Previously they always returned an xarray dataset with a data variable "x", but for the rc model the data_variable is named "r". Currently, there is no way of producing an analysis with multiple variable names (e.g. "wind" and "pressure"). These variables would have to be flattened into a single state vector before running DA. If this is a problem, we should add a github issue to this effect.

@kysolvik kysolvik requested a review from StevePny May 2, 2025 20:54
@kysolvik kysolvik marked this pull request as ready for review May 2, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants