exclude module from modulefinder parsing#6
Conversation
|
@adir-stratoscale please review |
|
Ha? @benoit-stratoscale, you really interested to change upseto? :) |
|
@rom-stratoscale @eliran-stratoscale Post mortem , for the sake of posterity : root cause : we upgrade gevent automatically to v1.1 ( released 9 of march ) which has a conditional import for supporting python2/3 Resolution :
Recommendation : FIX every dependency in order to avoid further issue , do not assume that because we have fix the top package all the dependency will stay the same. note modulefinder is patched to support conditional import in python 3.5 but tough luck for 2.7 ... http://bugs.python.org/issue17396 This will bite us again later , we are better off having the facility in to handle hybrid python2/3 lib now than waste time again with such stuff.. |
@abel-stratoscale @maor-stratoscale please review
This allow the exclusion from modulefinder path of specific module. This allow us to exclude dodgy python2/3 modules with conditional import like gevent