Conversation
- change switch restore_state to restore_mode as the former configuration option is not supported anymore - change `onboard_led` to be a status_led light platform, so it can be double purposed as both ESPHome Status LED and heating indicator - add some entity icons, device class
- API password is not supported anymore, it needs encryption
| pullup: True | ||
| name: ${unit_name}_active | ||
| id: power_active | ||
| device_class: power |
There was a problem hiding this comment.
I don't think that this device_class is right here. Its meant for current measuring in watts: https://developers.home-assistant.io/docs/core/entity/sensor/#:~:text=SensorDeviceClass.POWER
I suggest is to remove this line
There was a problem hiding this comment.
Nope, see: https://www.home-assistant.io/integrations/binary_sensor/#device-class
Binary sensors have device class, which sets the icon and the name (language specific) for the state corresponding to true/false (like open/closed, locked/unlocked powered on/powered off).
In this case, device class power: on means power detected, off means no power, with appropriate state translated to each language, plus a plug icon with state coloring.
There was a problem hiding this comment.
Ok, thank you for contributing.
|
Bump |
|
I don't have permissions to accept the PR. @Strooom merge please |
remove api/ota/etc as these are standard ESPHome config options to be seen in the doc. ota will soon change a bit, so no need to update this doc again, for something otherwise unrelated directly to this project
|
Ok, I'll take a look at it. |
|
Bump |
3 participants
restore_statetorestore_modeas the former configuration option is not supported anymorestatus_ledlight platform, so it can be double purposed as both ESPHome Status LED and heating indicator