Conversation
Co-authored-by: Myles Pasetsky <selym3@users.noreply.github.com> Co-authored-by: reyamiller <reyamiller@users.noreply.github.com>
Co-authored-by: Richie Xue <rxue40@stuy.edu> Co-authored-by: bananaeater321 <bananaeater321@users.noreply.github.com> Co-authored-by: reyamiller <reyamiller@users.noreply.github.com> Co-authored-by: Edgar694 <Cancelable@users.noreply.github.com>
Remove limp in Robot.java
- abstract Vision Data class - ReflectiveTapeData - VisionImpl and Odometry updated to work with both types of data Co-authored-by: Richie Xue <rxue40@stuy.edu>
| } | ||
|
|
||
| // 330.0 (-30.0 degrees) is the pitch of the limelight | ||
| return Angle.fromDegrees(Limelight.getInstance().getTargetYAngle() - 330.0); |
There was a problem hiding this comment.
Where is the 330 from? If its the limelight pitch, you should create a constant in Settings for it
|
|
||
| private Angle getYAngle() { | ||
| if (!hasAnyTarget()) { | ||
| // Settings.reportWarning("Unable To Find Target! [getYAngle() was called]"); |
There was a problem hiding this comment.
Just delete this line
| private final IntegerEntry idEntry; | ||
| private final DoubleArrayEntry blueBotposeEntry; | ||
| private final DoubleArrayEntry redBotposeEntry; | ||
| private final NetworkTableEntry txEntry; |
There was a problem hiding this comment.
I think this should be a double entry. You guys should also have an entry for ty and maybe tv for checking if you have data or not.
| @@ -64,6 +68,10 @@ private double[] getPoseData() { | |||
| redBotposeEntry.get(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Maybe implement a get distance function based off of Excelsior's code?
| public boolean hasAnyTarget() { | ||
| return Limelight.getInstance().getValidTarget(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe override the getPose function and just return a pose2d from the distance and angle you get from the reflective tape
There was a problem hiding this comment.
You guys also need to implement a swapping pipeline system for switching between reflective tape and apriltag mode
Look at this link for pipeline docs: https://docs.limelightvision.io/en/latest/networktables_api.html
peg align isn't done yet Co-authored-by: vincentw <vinowang921@gmail.com>
…rx/vision-pipline-switching
4 participants
No description provided.