Skip to content

Pq viet#7

Open
1DoiSimpEm wants to merge 8 commits intomasterfrom
PQViet
Open

Pq viet#7
1DoiSimpEm wants to merge 8 commits intomasterfrom
PQViet

Conversation

@1DoiSimpEm
Copy link
Collaborator

Anh nhận xét giúp em ạ

Copy link
Collaborator

@DuongLH-Sudo DuongLH-Sudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EM tìm hiểu xem còn cách nào giao tiếp giữa fragment-fragment và fragment-activity không?

setContentView(R.layout.activity_main2)
val tv_name = findViewById(R.id.tvName) as TextView
val tv_pass = findViewById(R.id.tvPass) as TextView
val btn_logout = findViewById(R.id.btnLogout) as Button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sao k dùng binding

}

binding.tvSignUp.setOnClickListener {
val FragmentSignUp = SignUpFragment()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xem lại cách đặt tên biến, anh đọc k biết là nó biến hay là class nữa

val FragmentLogin = LoginFragment()
//passing data
val bundle = Bundle()
FragmentLogin.arguments = bundle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

đặt tên biến khó chịu thật

android:layout_width="match_parent"
android:layout_height="wrap_content"
android:ems="10"
android:hint="Enter your password"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tránh hard code string

@1DoiSimpEm
Copy link
Collaborator Author

Dạ vâng ạ :( em không để ý phần đặt biến quá. Em sẽ rút kinh nghiệm ạ :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants