This repository was archived by the owner on Mar 23, 2025. It is now read-only.
Stopgap for Smash.gg Import function #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Smashboards user Demandatwin, these are the offending properties: https://smashboards.com/threads/skillkeeper-trueskill%E2%84%A2-rankings-bookkeeper.376590/page-8#post-21741867. While Demandatwin changed the bool to string to fix the importing on his local repo, ThreeFold changes the bool to object to fix the errors in deserializing the JSON to bool. Went with ThreeFold's way since he's more likely to contribute to this project. Might just need to change all bool properties if we're not using the JSON.NET package to deserialize. But since the smash.gg API will probably change again and break things, this is just a stopgap.