Open
Conversation
…element is visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have situation where I hide elements that have
scroll-indicatorclass. So I neededeasyScrollDotsto not display those. I see that you are mostly trying to not use jquery, so I attempted too, but admittedly, js is not my primary language. You may find a better way to implementisHidden. I simply used this https://stackoverflow.com/a/21696585/166231.Additionally, I re-organized the code to allow
easyScrollDotsto be called multiple times (i.e. after some visibility changes). Again, a few things to note: