Replace FillTypeFlags enum with a FillType strategy
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace FillTypeFlags.BridgeSupport with BridgeFillType
…d gcode Before the refactor, the OuterPerimeterSpeedX was being applied to inner perimeters as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor eliminates the
FillTypeFlagsenum. It is replaced by using the "Strategy" design pattern. There is now anIFillTypeinterface implemented by various classes to contain behavior related to specific fill types. For example, instead of calculating volume scaling based on the flag, the volume is scaled by a method on theIFillTypeimplementing classes.This makes the code more extensible, since derived code can define new fill types with custom behavior without being limited to the types in the
FillTypeFlagsenum as before.