This repository was archived by the owner on Nov 9, 2019. It is now read-only.
Add support for more node/edge attributes, provide array of nodes and edges as component parameter#3
Open
victor-nitu wants to merge 6 commits intoSuven:masterfrom
Open
Add support for more node/edge attributes, provide array of nodes and edges as component parameter#3victor-nitu wants to merge 6 commits intoSuven:masterfrom
victor-nitu wants to merge 6 commits intoSuven:masterfrom
Conversation
|
@Suven - do you still maintain this? This looks like a good feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for:
Now it's possible to provide an already build array of nodes AND an array of edges like this:
And also like this:
I haven't tested what happens if you provide both, probably some exception should be raised not allowing it, or maybe the component nodes/edges defined via hbs should be added to the provided arrays. To be determined :-)
Thanks for all the work on this, I'm going to remove my previously created PRs that are now a part of this bigger, improved one.