Open
Conversation
This commit refactors wallet-related types and functions, improving type safety and code organization. It also includes minor updates to utility functions for better consistency. Co-authored-by: authenticator.cursor.tubeless137 <authenticator.cursor.tubeless137@passmail.net>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for app-swiss-bitcoin-pay-ch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for swissbitcoinpayapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add View wrappers to various components for better structure. Update type assertions and fix minor issues in Bitbox API and SendModal. Co-authored-by: authenticator.cursor.tubeless137 <authenticator.cursor.tubeless137@passmail.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a significant number of TypeScript issues to improve type safety and reduce runtime errors.
This PR addresses 116 TypeScript errors across 20 files, reducing the total error count from 447 to 331. Key fixes include adding the
idproperty toStringPartobjects, resolving parameter type mismatches in various utility functions, improving the wallet type system by exporting missing types and correcting function signatures, and fixing hardware wallet integration issues related to Ledger and Trezor transaction signing.