Skip to content

Add environment variables to data-tasks supporting resource request tracking feature#4379

Merged
olevski merged 8 commits intorelease-2.15.0from
eikek/env-vars-data-tasks
Mar 4, 2026
Merged

Add environment variables to data-tasks supporting resource request tracking feature#4379
olevski merged 8 commits intorelease-2.15.0from
eikek/env-vars-data-tasks

Conversation

@eikek
Copy link
Member

@eikek eikek commented Feb 27, 2026

For allowing the data tasks to list k8s resources, some env var settings have been copied from the data-service deployment.

See SwissDataScienceCenter/renku-data-services#1207

/deploy

@eikek eikek requested a review from a team as a code owner February 27, 2026 10:52
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eike this looks good. But lets do this:

  1. Merge the stuff in data services
  2. Tag a data services release
  3. Update the data services in this repo with the new release
  4. Deploy once more here to check everything is ok

Then we merge.

Also I think we should have a switch in the values file to turn this off. I think we discussed something like that. In case things get out of hand and the DB fills up too quickly.

I would even keep this flag turned off by default first and then we flip it to ON by default later.

@eikek eikek force-pushed the eikek/env-vars-data-tasks branch from d88f20b to 27c6673 Compare March 4, 2026 11:10
@eikek eikek force-pushed the eikek/env-vars-data-tasks branch 2 times, most recently from 545a1fd to af25160 Compare March 4, 2026 13:08
@eikek eikek requested a review from a team as a code owner March 4, 2026 14:56
@RenkuBot
Copy link
Collaborator

RenkuBot commented Mar 4, 2026

You can access the deployment of this PR at https://ci-renku-4379.dev.renku.ch

@eikek eikek force-pushed the eikek/env-vars-data-tasks branch from 8fece65 to 2a6e9af Compare March 4, 2026 15:23
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small last fixes. With this the K8S_CONFIGS_ROOT env variable will truly work.

@olevski olevski self-requested a review March 4, 2026 15:48
@olevski olevski enabled auto-merge (squash) March 4, 2026 16:08
@olevski olevski merged commit e851172 into release-2.15.0 Mar 4, 2026
94 of 105 checks passed
@olevski olevski deleted the eikek/env-vars-data-tasks branch March 4, 2026 16:39
@RenkuBot
Copy link
Collaborator

RenkuBot commented Mar 4, 2026

Tearing down the temporary RenkuLab deployment for this PR.

olevski pushed a commit that referenced this pull request Mar 4, 2026
* Add env var for resource usage and set service account for data-task

* Update data services to 0.71.0
olevski added a commit that referenced this pull request Mar 5, 2026
* chore(deps): bump urllib3 from 2.6.0 to 2.6.3 in /global-images/datascience (#4304)

* chore(deps): bump urllib3 in /global-images/datascience

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.0 to 2.6.3.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.6.0...2.6.3)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump numpy from 2.3.5 to 2.4.0 in /global-images/datascience in the python group across 1 directory (#4298)

* feat: add option to disable ClusterRoles

* add docs

* feat: add session alerts (#4267)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Degano <a.degano@gmail.com>
Co-authored-by: Wes Johnson <515042+wesjdj@users.noreply.github.com>
Co-authored-by: Rok Roškar <roskarr@ethz.ch>
Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>

* chore: more v1 cleanup (#4335)

* chore(gateway): remove now unused configuration

Following update of renku-gateway, these two entries
are now not required anymore.

* chore: remove enableV1Services from minimal deployment example

---------

Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>

* chore: remove v1 documentation (#4354)

* chore: remove v1 acceptance tests (#4353)

* chore: Disable Gitlab connection for CI deployments

* feat: Upgrade Keycloak to 25.0.0

* fix: remove secret for client renku-cli (#4371)

Fixes `renku-cli` being re-created on every `helm upgrade` because the client has no secret now.

* feat: add support for using OAuth 2.0 integrations with data connectors (#4367)

Add support for using OAuth 2.0 integrations with data connectors. This allows users to connect Renku with their Google and Dropbox accounts and use Google Drive and Dropbox in their sessions as mounts.

* feat: move git-https-server to amalthea (#4363)

* fix: mismatched service account in helm chart (#4366)

* feat(chart): add logging format (#4374)

* feat: upgrade csi-rclone to 0.6.0 (#4384)

* feat: Upgrade Buildpacks Builder Version 0.3.1 (#4380)

* docs: add user page about google drive and dropbox (#4385)

* feat: add capacity reservation (#4364)

* docs: add the renku social card (#4387)

* feat: update search page (#4369)

* upgrade renku-ui to 4.19.0

* upgrade renku-data-service to 0.70.0

* chore: update tests and UI memory

---------

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

* feat: resource request tracking (#4379)

* Add env var for resource usage and set service account for data-task

* Update data services to 0.71.0

* feat(helm): disable internal gitlab by default (#4391)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Degano <a.degano@gmail.com>
Co-authored-by: Wes Johnson <515042+wesjdj@users.noreply.github.com>
Co-authored-by: Rok Roškar <roskarr@ethz.ch>
Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Co-authored-by: Mohammad Alisafaee <mohammad.alisafaee@epfl.ch>
Co-authored-by: Salim Kayal <salim.kayal@idiap.ch>
Co-authored-by: Andrea Cordoba <43388408+andre-code@users.noreply.github.com>
Co-authored-by: eikek <701128+eikek@users.noreply.github.com>
ciyer pushed a commit that referenced this pull request Mar 6, 2026
* chore(deps): bump urllib3 from 2.6.0 to 2.6.3 in /global-images/datascience (#4304)

* chore(deps): bump urllib3 in /global-images/datascience

Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.0 to 2.6.3.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.6.0...2.6.3)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-version: 2.6.3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump numpy from 2.3.5 to 2.4.0 in /global-images/datascience in the python group across 1 directory (#4298)

* feat: add option to disable ClusterRoles

* add docs

* feat: add session alerts (#4267)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Degano <a.degano@gmail.com>
Co-authored-by: Wes Johnson <515042+wesjdj@users.noreply.github.com>
Co-authored-by: Rok Roškar <roskarr@ethz.ch>
Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>

* chore: more v1 cleanup (#4335)

* chore(gateway): remove now unused configuration

Following update of renku-gateway, these two entries
are now not required anymore.

* chore: remove enableV1Services from minimal deployment example

---------

Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>

* chore: remove v1 documentation (#4354)

* chore: remove v1 acceptance tests (#4353)

* chore: Disable Gitlab connection for CI deployments

* feat: Upgrade Keycloak to 25.0.0

* fix: remove secret for client renku-cli (#4371)

Fixes `renku-cli` being re-created on every `helm upgrade` because the client has no secret now.

* feat: add support for using OAuth 2.0 integrations with data connectors (#4367)

Add support for using OAuth 2.0 integrations with data connectors. This allows users to connect Renku with their Google and Dropbox accounts and use Google Drive and Dropbox in their sessions as mounts.

* feat: move git-https-server to amalthea (#4363)

* fix: mismatched service account in helm chart (#4366)

* feat(chart): add logging format (#4374)

* feat: upgrade csi-rclone to 0.6.0 (#4384)

* feat: Upgrade Buildpacks Builder Version 0.3.1 (#4380)

* docs: add user page about google drive and dropbox (#4385)

* feat: add capacity reservation (#4364)

* docs: add the renku social card (#4387)

* feat: update search page (#4369)

* upgrade renku-ui to 4.19.0

* upgrade renku-data-service to 0.70.0

* chore: update tests and UI memory

---------

Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>

* feat: resource request tracking (#4379)

* Add env var for resource usage and set service account for data-task

* Update data services to 0.71.0

* feat(helm): disable internal gitlab by default (#4391)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessandro Degano <a.degano@gmail.com>
Co-authored-by: Wes Johnson <515042+wesjdj@users.noreply.github.com>
Co-authored-by: Rok Roškar <roskarr@ethz.ch>
Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>
Co-authored-by: Samuel Gaist <samuel.gaist@idiap.ch>
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
Co-authored-by: Mohammad Alisafaee <mohammad.alisafaee@epfl.ch>
Co-authored-by: Salim Kayal <salim.kayal@idiap.ch>
Co-authored-by: Andrea Cordoba <43388408+andre-code@users.noreply.github.com>
Co-authored-by: eikek <701128+eikek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants