refactor(auth): update Google authentication handling and improve tests#1534
Draft
tyler-dane wants to merge 1 commit intomainfrom
Draft
refactor(auth): update Google authentication handling and improve tests#1534tyler-dane wants to merge 1 commit intomainfrom
tyler-dane wants to merge 1 commit intomainfrom
Conversation
- Renamed `sessionUserId` to `compassUserId` in `parseReconnectGoogleParams` for clarity. - Refactored `CompassAuthService` to enhance Google connection assessment and streamline authentication modes. - Introduced `determineGoogleAuthMode` to manage different authentication scenarios, including new user sign-ups and reconnect repairs. - Updated tests to reflect changes in authentication logic and ensure accurate handling of Google sign-in success scenarios. - Removed deprecated Google auth intent handling from various components and hooks for cleaner code. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Codex's version)
sessionUserIdtocompassUserIdinparseReconnectGoogleParamsfor clarity.CompassAuthServiceto enhance Google connection assessment and streamline authentication modes.determineGoogleAuthModeto manage different authentication scenarios, including new user sign-ups and reconnect repairs.Co-authored-by: Tyler Dane tyler-dane@users.noreply.github.com