Add setting to prevent auto-playing when you're alone in the room

[xboxfanj]

No description provided.

[xboxfanj]

This is a nice quality of life improvement for my workflow. If I join a room first and open the video first, I'd rather wait until others join before I start watching. Otherwise, I'm having to rewind to the beginning, pause, and set myself to Ready again. Please let me know if I'm just missing another way to do this.

[Et0h]

I'm not sure of your use case or reproduction instructions are for the behaviour you are trying to avoid (auto-playing when you're alone in the room).

The way the code ought to already be working is that auto-play only executes when it is enabled and when the minimum user threshold (2 by default) is met. If you are alone the user count should only be 1 so it shouldn't activate.

[Et0h]

I found a way to reproduce the bug for VLC users, but not for other players:

• Go into rooms with no playlist loading a file via the Load media file option in the Syncplay menu.
• Go to a different room which is also empty and has no playlist.
• Load a file via the Load media file option in the Syncplay menu.

If that's your experience too then I expect that this is a bug probably needs to be fixed somewhere in vlc.py or if there's a relevant command line switch then constants.py.

[Et0h]

One potential fix is to add the following to the end of openFile in vlc.py (unintended):
self._listener.sendLine('set-playstate: {}'.format("paused" if self._paused else "playing"))

This would need testing to see if it caused issues, but seemed to work in my quick test.

It's possible it actually wants to be:
self._listener.sendLine('set-playstate: {}'.format("paused")

[xboxfanj]

I use IINA. This was happening for me, but I haven't been able to reproduce it since upgrading to 1.4.0. Not sure if that was the fix.

[Et0h]

@xboxfanj Fingers crossed that IINA 1.4.0 has fixed everything. Unless I hear otherwise I'll assume the problem has been solved for IINA.

I don't use VLC so am not in a good position to test the potential VLC issue - I'll leave this issue open for a while to see if anyone who uses VLC or IINA want to come in to report any problems and, for VLC, to test the potential solutions.

If nobody reports anything after a while I'll close it and we can always re-open it if someone experienced a problem.

[xboxfanj]

Sounds good. I have not been able to reproduce this issue since I commented last. I was on a self-compiled prerelease build of IINA from a few months ago, so it could have been an IINA bug and completely unrelated to syncplay. IINA 1.4.0 and 1.4.1 have both worked fine.

[TheCrazyLex]

Would love for this feature to ship, I regularly go into suspend with my macbook while intending to stay or be able to quickly reconnect to my room

[Et0h]

Would love for this feature to ship, I regularly go into suspend with my macbook while intending to stay or be able to quickly reconnect to my room

Did you intend to post this to #739 ?

[TheCrazyLex]

Would love for this feature to ship, I regularly go into suspend with my macbook while intending to stay or be able to quickly reconnect to my room

Did you intend to post this to #739 ?

Yeah, I mixed these up as I get emails on both. Sorry about that.