Add unit tests for executor-assignment module#256
Add unit tests for executor-assignment module#256nikolasdehor wants to merge 1 commit intoSynkraAI:mainfrom
Conversation
|
@nikolasdehor is attempting to deploy a commit to the Pedro Valério Lopez's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds Jest unit test coverage for the .aios-core/core/orchestration/executor-assignment module to validate story-type detection and executor/quality-gate assignment behaviors.
Changes:
- Introduces comprehensive unit tests for exported constants and utility functions.
- Adds coverage for
detectStoryType,assignExecutor,assignExecutorFromContent, andvalidateExecutorAssignment. - Verifies expected executor/quality gate mappings and validation error cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jest.resetAllMocks(); | ||
| jest.spyOn(console, 'warn').mockImplementation(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
beforeEach creates a new jest.spyOn(console, 'warn') but the spy is never restored. Since jest.resetAllMocks() does not restore the original implementation, this can leave console.warn mocked across the suite and may break subsequent spyOn calls. Add an afterEach(() => jest.restoreAllMocks()) (or console.warn.mockRestore()), and consider replacing resetAllMocks() with clearAllMocks() if you only need call-history resets.
| afterEach(() => { | |
| jest.restoreAllMocks(); | |
| }); |
|
Consolidated into #426 |
Summary
executor-assignmentorchestration moduleTest Coverage
Test plan
Closes #305