Skip to content

chore: auditoria de lifecycle — depreca scripts legados (#90) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolasdehor wants to merge 1 commit into
base: main
Choose a base branch
from
+315 −25
Open

chore: auditoria de lifecycle — depreca scripts legados (#90) #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 122 additions & 0 deletions .aiox-core/core/docs/orchestration-hierarchy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
# Hierarquia de Orquestradores - AIOX Core

> Issue: #90 - Script lifecycle audit
> EPIC12-F4 - Documentacao de coexistencia

## Visao Geral

O AIOX possui tres orquestradores que operam em camadas complementares. Nenhum conflita com os outros -- cada um tem escopo e responsabilidades distintas.

```
MasterOrchestrator (Epic 0)
|-- Ativacao de agentes, roteamento de comandos
|-- Pipeline completo: Epics 3 -> 4 -> 5 -> 6
|
BobOrchestrator (Epic 12)
|-- Decision tree do PM agent
|-- Story-driven, multi-agent orchestration
|-- Integra todos os modulos Epic 11
|
WorkflowOrchestrator (Core)
|-- Engine de execucao de workflows
|-- Multi-agent phase dispatch
|-- Pre-Flight detection, skill dispatch
```

## Detalhamento

### 1. MasterOrchestrator

| Campo | Valor |
|-------|-------|
| **Path** | `.aiox-core/core/orchestration/master-orchestrator.js` |
| **Epic** | Epic 0 (ADE - Autonomous Development Engine) |
| **Story** | 0.1 - Master Orchestrator Core |
| **Escopo** | Orquestracao central do pipeline de desenvolvimento autonomo |

**Responsabilidades:**
- `executeFullPipeline()` — executa Epics 3, 4, 5, 6 em sequencia
- `executeEpic(epicNum)` — execucao individual de um epic
- `resumeFromEpic(epicNum)` — retomada de ponto especifico
- State machine: INITIALIZED -> READY -> IN_PROGRESS -> BLOCKED -> COMPLETE
- Integracao com TechStackDetector para pre-flight detection

**Quando usar:** Pipeline completo de desenvolvimento autonomo, ativacao de agentes no nivel mais alto.

---

### 2. BobOrchestrator

| Campo | Valor |
|-------|-------|
| **Path** | `.aiox-core/core/orchestration/bob-orchestrator.js` |
| **Epic** | Epic 12 (Projeto Bob) |
| **Story** | 12.3 - Bob Orchestration Logic (Decision Tree) |
| **Escopo** | PM agent routing via decision tree codificada |

**Responsabilidades:**
- Detecta estado do projeto e roteia para workflow correto
- Integra TODOS os modulos Epic 11:
- ExecutorAssignment (11.1) — selecao de agente
- TerminalSpawner (11.2) — spawn de agentes
- WorkflowExecutor (11.3) — ciclo de desenvolvimento
- SurfaceChecker (11.4) — criterios de decisao humana
- SessionState (11.5) — persistencia de sessao
- Decision tree sem LLM (roteamento deterministico)
- Constraint: < 50 linhas de logica especifica de outros agentes

**Quando usar:** Orquestracao story-driven multi-agente via PM.

---

### 3. WorkflowOrchestrator

| Campo | Valor |
|-------|-------|
| **Path** | `.aiox-core/core/orchestration/workflow-orchestrator.js` |
| **Epic** | Core (pre-Epic 11) |
| **Escopo** | Engine de execucao de workflows multi-agente |

**Responsabilidades:**
- Executa workflows com subagentes reais (persona transformation)
- Cada fase despacha para agente especializado
- Integracao com:
- SubagentPromptBuilder — construcao de prompts
- ContextManager — gerenciamento de contexto
- ParallelExecutor — execucao paralela
- ChecklistRunner — execucao de checklists
- TechStackDetector (V3.1) — pre-flight detection
- ConditionEvaluator, SkillDispatcher — dispatch condicional

**Quando usar:** Execucao de workflows que envolvem multiplos agentes com fases definidas.

---

## Relacao Entre Orquestradores

```
Requisicao do usuario
|
v
MasterOrchestrator (ativa agente)
|
|-- Se PM/Bob --> BobOrchestrator (decision tree)
| |
| v
| WorkflowExecutor (ciclo dev)
| |
| v
| WorkflowOrchestrator (executa fases)
|
|-- Se outro agente --> execucao direta ou task
```

## Modulos Deprecados (ver docs/deprecated-scripts.md)

| Modulo Legado | Substituto | Status |
|---------------|-----------|--------|
| `workflow-state-manager.js` | `session-state.js` | @deprecated |
| `workflow-navigator.js` | `bob-orchestrator.js` + `session-state.js` | @deprecated (semi) |
| `command-execution-hook.js` | `session-state.js` | @deprecated |

Estes modulos ainda existem para backward compatibility mas nao devem ser usados em codigo novo.
11 changes: 11 additions & 0 deletions .aiox-core/development/scripts/workflow-navigator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
/**
* Workflow Navigator - Next-Step Suggestions for Workflow State
*
* @deprecated Semi-deprecated since Epic 11/12. Bob Orchestrator (Story 12.3)
* now handles workflow routing via codified decision tree, and SessionState
* (Story 11.5) manages session persistence. This module may still be used
* by greeting-builder.js and unified-activation-pipeline.js for legacy
* command suggestion flows. New workflow navigation should use:
* - .aiox-core/core/orchestration/bob-orchestrator.js (decision routing)
* - .aiox-core/core/orchestration/session-state.js (state persistence)
* - .aiox-core/core/orchestration/workflow-executor.js (execution engine)
*
* Provides intelligent next-step command suggestions based on:
* - Current workflow state (detected from command history)
* - Workflow transitions (defined in workflow-patterns.yaml)
Expand All @@ -12,6 +21,8 @@
* - Numbered list formatting for user selection
*/

console.warn('[DEPRECATED] workflow-navigator.js — workflow routing now handled by bob-orchestrator.js (Story 12.3) and session-state.js (Story 11.5)');

const fs = require('fs');
const path = require('path');
const yaml = require('js-yaml');
Expand Down
2 changes: 2 additions & 0 deletions .aiox-core/development/scripts/workflow-state-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
* @version 2.0.0
*/

console.warn('[DEPRECATED] workflow-state-manager.js — use .aiox-core/core/orchestration/session-state.js instead (Story 11.5)');

const fs = require('fs').promises;
const path = require('path');
const yaml = require('js-yaml');
Expand Down
44 changes: 24 additions & 20 deletions .aiox-core/install-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
# - File types for categorization
#
version: 5.0.3
generated_at: "2026-03-11T15:04:09.395Z"
generated_at: "2026-03-12T18:49:52.538Z"
generator: scripts/generate-install-manifest.js
file_count: 1090
file_count: 1091
files:
- path: cli/commands/config/index.js
hash: sha256:25c4b9bf4e0241abf7754b55153f49f1a214f1fb5fe904a576675634cb7b3da9
Expand Down Expand Up @@ -284,6 +284,10 @@ files:
hash: sha256:3505471b0adff9bfcea08f46cca3aeeda46a283bbe7ee711dd566e5974c3257f
type: template
size: 721
- path: core/docs/orchestration-hierarchy.md
hash: sha256:86daaa7fbc1f7b1f62466c929c523ad5a807ea44d50c87ad302ac34191b775e3
type: documentation
size: 4060
- path: core/doctor/checks/agent-memory.js
hash: sha256:08d5d685e4fdaaedf081020229844f4a58c9fd00244e4c37eb5b3fd78f4feb61
type: core
Expand Down Expand Up @@ -1705,13 +1709,13 @@ files:
type: script
size: 15887
- path: development/scripts/workflow-navigator.js
hash: sha256:45bd9f0317b6a0b9e9577b5b26550f1b7fafec2c45c1b542a6947ffd69a70fec
hash: sha256:43e3fb1a9655a06bcfd54d450b0e6e079fbb3f292673afd86afbe4adb578c6de
type: script
size: 9847
size: 10595
- path: development/scripts/workflow-state-manager.js
hash: sha256:3a896079b32b8efb8c532c0626c4ce14fb52cc92afbb086f6f2d2a0367d60dec
hash: sha256:5300937308b430285891afda757ea83ccf20fcdd64005a870c06f3b072c0ee06
type: script
size: 20129
size: 20262
- path: development/scripts/workflow-validator.js
hash: sha256:abb16e5cd34ec06bbca0a31af3fc500c3a5c98f66d0a72546e4a2827653abcd3
type: script
Expand Down Expand Up @@ -4073,21 +4077,21 @@ files:
type: script
size: 8761
- path: scripts/batch-migrate-phase1.ps1
hash: sha256:c1f72c94244b7fe8f1f5cf12f0eb2cea017aeaca620953ede02c5c8f0125b429
hash: sha256:6f9d7117cee5a9180a9ff952ea9b2a9cc66d0365b76bdd4e3ba879329636da99
type: script
size: 974
size: 1333
- path: scripts/batch-migrate-phase2.ps1
hash: sha256:9f7d0a90fec3c2553cd5b757765b15839a0eeefb040fe6e23d58faa801eefe61
hash: sha256:290b25e360894ea33b6fda3bef572b57e49292bed516221eb89b9cc77fa03814
type: script
size: 2591
size: 2950
- path: scripts/batch-migrate-phase3.ps1
hash: sha256:5555a7095693dd7a64be48c6fb0e03b706a68ffd66af9edebac65b798dc4f2bb
hash: sha256:eadbccd740b43fa430e590d6412fecc53bc0e45bcc457d6dfce5c7ded526b1c1
type: script
size: 1492
size: 1851
- path: scripts/command-execution-hook.js
hash: sha256:295663ee1d236c1085f359773c8940a2cb05cea648e39ef1f02f745a3e7d0990
hash: sha256:43360a859c8d1701b2dc05cd32b9451227daa30c268fc7296f0cae4c850f86d0
type: script
size: 5047
size: 5518
- path: scripts/diagnostics/diagnose-installation.js
hash: sha256:a3e2dc1b3630d6c14098a7becf007caeb7ecf5ded72b1d2be116fdc8b5778fe4
type: script
Expand Down Expand Up @@ -4257,9 +4261,9 @@ files:
type: script
size: 4468
- path: scripts/migrate-framework-docs.sh
hash: sha256:535844ae659e1cb4d35658cde8379b64a4195ff62ee84d048b9a5c7249f5b617
hash: sha256:b6380908affc59158594a7cbeaf737b0a755ff12d99a8bf6527e0f6c616154ec
type: script
size: 9488
size: 9837
- path: scripts/pm.sh
hash: sha256:ee33d9c7cd88a4d537bf2dc8c89c734f3e6027fc7d0cf4c668066e6c600e7e3a
type: script
Expand All @@ -4269,9 +4273,9 @@ files:
type: script
size: 4527
- path: scripts/session-context-loader.js
hash: sha256:c994dcd432125f969e1bf1b9eac2b1511b02722b7e73f16aa20db3d2fb4d0b90
hash: sha256:bf7aab6da9feda285bab0d5456e7eb412289a85687a671e117a141264a2a4cfa
type: script
size: 1583
size: 1717
- path: scripts/test-template-system.js
hash: sha256:a9950ff166530e657ac7fb64fb1b121fa2d909371618e35a0543c554a34be435
type: script
Expand All @@ -4281,9 +4285,9 @@ files:
type: script
size: 6083
- path: scripts/validate-phase1.ps1
hash: sha256:ea9f40a265c44fffeb859f5041f7d7cbcd49322d3f0c0d88949f8ac8b7c25c15
hash: sha256:26402ca0e4d97c0f1671222fccab463435b83d8d464e4771c6b6e8d1ce29f971
type: script
size: 768
size: 1053
- path: scripts/workflow-management.md
hash: sha256:fae596f7be326f897fafeab252fdffd2c6d6cb3163f31f71a4c01d5c88e79930
type: script
Expand Down
5 changes: 5 additions & 0 deletions .aiox-core/scripts/batch-migrate-phase1.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# @deprecated One-time migration script (Task V2.0 migration, completed).
# All tasks have been migrated to V2.0 format. This script is no longer needed.
# Replacement: tasks are now natively V2.0 — use validate-task-v2.js for validation.
Write-Warning "[DEPRECATED] batch-migrate-phase1.ps1 — migration already completed. Tasks are V2.0 natively."
Comment on lines +1 to +4
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Do not keep the legacy write path enabled by default.

This now advertises itself as a completed migration, but a plain run still executes the phase-1 rewrite loop below. That is a risky default for a deprecated script. Please warn and return unless the caller explicitly passes a force flag.

🧰 Tools
🪛 PSScriptAnalyzer (1.24.0)

[warning] Missing BOM encoding for non-ASCII encoded file 'batch-migrate-phase1.ps1'

(PSUseBOMForUnicodeEncodedFile)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/batch-migrate-phase1.ps1 around lines 1 - 4, Add a guard
that prevents the deprecated batch-migrate-phase1.ps1 from performing any
rewrites unless an explicit force flag is provided: add a param for a
[switch]$Force (or check for a -Force/$force parameter) at the top, update the
existing Write-Warning to state the script is deprecated and requires --Force to
proceed, and immediately return/exit when -Force is not present so the phase-1
rewrite loop below never runs by default; only continue to the rewrite logic
when $Force is set.


# Phase 1 - Batch migrate critical tasks

$tasks = @(
Expand Down
5 changes: 5 additions & 0 deletions .aiox-core/scripts/batch-migrate-phase2.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# @deprecated One-time migration script (Task V2.0 migration, completed).
# All tasks have been migrated to V2.0 format. This script is no longer needed.
# Replacement: tasks are now natively V2.0 — use validate-task-v2.js for validation.
Write-Warning "[DEPRECATED] batch-migrate-phase2.ps1 — migration already completed. Tasks are V2.0 natively."
Comment on lines +1 to +4
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Make the deprecated entrypoint opt-in before running the migration loop.

The new banner says this migration is already complete, but a normal invocation still proceeds to rewrite the fixed task list below. That makes accidental runs risky on already-migrated files. Safer default: warn and exit unless a -Force/-RunDeprecatedScript flag is passed.

🧰 Tools
🪛 PSScriptAnalyzer (1.24.0)

[warning] Missing BOM encoding for non-ASCII encoded file 'batch-migrate-phase2.ps1'

(PSUseBOMForUnicodeEncodedFile)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/batch-migrate-phase2.ps1 around lines 1 - 4, Add an
opt-in guard to the batch-migrate-phase2.ps1 entrypoint: define a switch
parameter (e.g. -Force or -RunDeprecatedScript) at the top via a Param() block
and, before the existing migration loop, check if the switch is present; if not,
emit the deprecation Write-Warning and exit/return immediately so the rest of
the script (the migration loop that rewrites tasks) does not run. Ensure the
check is placed before any file-modifying logic and reference the script name
batch-migrate-phase2.ps1 and the migration loop block when making the change.


# Phase 2 - Batch migrate agent-specific tasks (50 tasks)

$tasks = @(
Expand Down
5 changes: 5 additions & 0 deletions .aiox-core/scripts/batch-migrate-phase3.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# @deprecated One-time migration script (Task V2.0 migration, completed).
# All tasks have been migrated to V2.0 format. This script is no longer needed.
# Replacement: tasks are now natively V2.0 — use validate-task-v2.js for validation.
Write-Warning "[DEPRECATED] batch-migrate-phase3.ps1 — migration already completed. Tasks are V2.0 natively."

# Phase 3 - Batch migrate remaining utility & support tasks

# Get all remaining non-compliant tasks
Expand Down
18 changes: 13 additions & 5 deletions .aiox-core/scripts/command-execution-hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
#!/usr/bin/env node
/**
* Command Execution Hook
*
*
* @deprecated Superseded by SessionState (Story 11.5) which provides unified
* session state persistence with crash recovery, phase tracking, and epic/story
* context. This script's simple command-history tracking is now a subset of
* SessionState's capabilities. New code should use:
* - .aiox-core/core/orchestration/session-state.js
*
* Updates session state after command execution for workflow continuity.
*
*
* Responsibilities:
* - Track command execution history
* - Update session type (new → existing → workflow)
* - Update session type (new -> existing -> workflow)
* - Record agent transitions
* - Enable intelligent greeting adaptation
*
*
* Usage:
* const { updateSessionAfterCommand } = require('./command-execution-hook');
* await updateSessionAfterCommand(agentId, commandName);
*
*
* Part of Story 6.1.4: Unified Greeting System Integration
*/

console.warn('[DEPRECATED] command-execution-hook.js — use .aiox-core/core/orchestration/session-state.js instead (Story 11.5)');

const fs = require('fs').promises;
const path = require('path');

Expand Down
6 changes: 6 additions & 0 deletions .aiox-core/scripts/migrate-framework-docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
#
# AIOX Framework Documentation Migration Script
#
# @deprecated One-time migration script (Story 6.1.2.6, completed).
# Framework docs have been migrated to aiox-core. This script is no longer needed.
# Documentation now lives natively in docs/ and .aiox-core/docs/.
#
# Purpose: Migrate framework docs from aiox-fullstack to aiox-core (REPO 1)
# Story: 6.1.2.6 - Framework Configuration System
# Execution Timeline: Q2 2026 (Repository Migration Phase)
Expand All @@ -15,6 +19,8 @@
# --help Show this help message
#

echo "[DEPRECATED] migrate-framework-docs.sh — migration already completed. Docs live natively in docs/ and .aiox-core/docs/."
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Stop after the deprecation banner unless the user explicitly opts in.

After printing this message, the script still executes the full migration flow and can overwrite docs in the target repo. For a one-off script now declared complete, the safe default should be to exit here and require an explicit --force-legacy-run flag for any remaining use.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/migrate-framework-docs.sh at line 22, Modify
migrate-framework-docs.sh to stop execution immediately after printing the
deprecation banner unless the user passed an explicit opt-in flag; check
positional/parsed args for a --force-legacy-run (or similar) flag and only
proceed with the existing migration flow when that flag is present, otherwise
call exit 0 right after the echo "[DEPRECATED] ..." line to prevent any further
actions; update any help/usage text to document the --force-legacy-run opt-in
and reference the script name migrate-framework-docs.sh in your changes so
reviewers can find the guard easily.


set -e # Exit on error

# Colors for output
Expand Down
2 changes: 2 additions & 0 deletions .aiox-core/scripts/session-context-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

'use strict';

console.warn('[DEPRECATED] session-context-loader.js — use require(\'.aiox-core/core/session/context-loader\') directly (WIS-3)');
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Locate the file
find . -name "session-context-loader.js" -type f

Repository: SynkraAI/aiox-core

Length of output: 166

🏁 Script executed:

# Check if the path exists and read the file around lines 18-21
ls -la ".aiox-core/scripts/session-context-loader.js" 2>/dev/null || find . -path "*aiox-core*" -name "session-context-loader.js"

Repository: SynkraAI/aiox-core

Length of output: 155

🏁 Script executed:

# Search for any configuration that might establish a .aiox-core alias
find . -name "package.json" -o -name "tsconfig.json" | head -20

Repository: SynkraAI/aiox-core

Length of output: 418

🏁 Script executed:

cat -n ".aiox-core/scripts/session-context-loader.js"

Repository: SynkraAI/aiox-core

Length of output: 2101

🏁 Script executed:

# Check the root package.json for any path aliases or resolution config
cat "./.aiox-core/package.json"

Repository: SynkraAI/aiox-core

Length of output: 2557

🏁 Script executed:

# Also check the repo root package.json
cat "./package.json" | head -100

Repository: SynkraAI/aiox-core

Length of output: 4910

🏁 Script executed:

# Verify the path validity by checking what the actual import resolves to
ls -la ".aiox-core/core/session/context-loader.js" 2>/dev/null || echo "File not found at that path"

Repository: SynkraAI/aiox-core

Length of output: 153

🏁 Script executed:

# Double-check the relative path from the script location
cd ".aiox-core/scripts" && ls -la "../core/session/context-loader.js" 2>/dev/null || echo "File not found"

Repository: SynkraAI/aiox-core

Length of output: 145

Fix the replacement require() path in the deprecation warning.

The path in the warning (require('.aiox-core/core/session/context-loader')) is invalid Node.js syntax and will cause a MODULE_NOT_FOUND error at runtime. In Node.js, require paths must start with ./, ../, or be module names—a leading . without a slash is not valid. Update the message to match the actual import on line 21: require('../core/session/context-loader').

Suggested fix 
-console.warn('[DEPRECATED] session-context-loader.js — use require(\'.aiox-core/core/session/context-loader\') directly (WIS-3)');
+console.warn('[DEPRECATED] session-context-loader.js — use require(\'../core/session/context-loader\') directly (WIS-3)');
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
console.warn('[DEPRECATED] session-context-loader.js — use require(\'.aiox-core/core/session/context-loader\') directly (WIS-3)');
console.warn('[DEPRECATED] session-context-loader.js — use require(\'../core/session/context-loader\') directly (WIS-3)');
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/session-context-loader.js at line 18, The deprecation
warning string in session-context-loader.js contains an invalid require path;
update the console.warn call that currently references
"require('.aiox-core/core/session/context-loader')" to use the correct Node.js
relative import "require('../core/session/context-loader')" so the message
matches the actual import used on line 21 and avoids a MODULE_NOT_FOUND error.


// Re-export from canonical location
const SessionContextLoader = require('../core/session/context-loader');

Expand Down
4 changes: 4 additions & 0 deletions .aiox-core/scripts/validate-phase1.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# @deprecated One-time validation script for Task V2.0 Phase 1 migration.
# Migration is complete. Use validate-task-v2.js directly for ongoing validation.
Write-Warning "[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use validate-task-v2.js directly."
Comment on lines +2 to +3
Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Point the warning at the real replacement path.

The new deprecation message tells users to run validate-task-v2.js directly, but the replacement script lives under .aiox-core/development/scripts/validate-task-v2.js in this repo, not .aiox-core/scripts/. As written, the migration guidance is ambiguous and currently disagrees with the stale invocation at Line 26.

Suggested update 
-# Migration is complete. Use validate-task-v2.js directly for ongoing validation.
-Write-Warning "[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use validate-task-v2.js directly."
+# Migration is complete. Use .aiox-core/development/scripts/validate-task-v2.js directly for ongoing validation.
+Write-Warning "[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use .aiox-core/development/scripts/validate-task-v2.js directly."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Migration is complete. Use validate-task-v2.js directly for ongoing validation.
Write-Warning "[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use validate-task-v2.js directly."
# Migration is complete. Use .aiox-core/development/scripts/validate-task-v2.js directly for ongoing validation.
Write-Warning "[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use .aiox-core/development/scripts/validate-task-v2.js directly."
🧰 Tools
🪛 PSScriptAnalyzer (1.24.0)

[warning] Missing BOM encoding for non-ASCII encoded file 'validate-phase1.ps1'

(PSUseBOMForUnicodeEncodedFile)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/validate-phase1.ps1 around lines 2 - 3, The deprecation
warning in validate-phase1.ps1 points to the wrong replacement; update the
warning text to reference the actual replacement script name validate-task-v2.js
in its correct location and make the message unambiguous, and also correct the
stale invocation elsewhere in the same validate-phase1.ps1 file (the existing
call to the old path) so both the warning and the invocation consistently point
to the new validate-task-v2.js entrypoint.

Copy link

@coderabbitai coderabbitai bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
python - <<'PY'
from pathlib import Path

p = Path(".aiox-core/scripts/validate-phase1.ps1")
data = p.read_bytes()

has_bom = data.startswith(b"\xef\xbb\xbf")
has_non_ascii = any(b > 0x7F for b in data)

print(f"file={p}")
print(f"utf8_bom={has_bom}")
print(f"contains_non_ascii={has_non_ascii}")
PY

Repository: SynkraAI/aiox-core

Length of output: 144

Save this file as UTF-8 with BOM to properly encode the Unicode characters, or remove the em-dash from the warning message.

The file currently contains non-ASCII characters (the em-dash on line 3) but lacks a UTF-8 BOM. This mismatch causes PSScriptAnalyzer to flag PSUseBOMForUnicodeEncodedFile, and Windows PowerShell 5.1 may garble the warning text when loading from disk without the proper encoding marker.

🧰 Tools
🪛 PSScriptAnalyzer (1.24.0)

[warning] Missing BOM encoding for non-ASCII encoded file 'validate-phase1.ps1'

(PSUseBOMForUnicodeEncodedFile)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.aiox-core/scripts/validate-phase1.ps1 at line 3, The Write-Warning string
in validate-phase1.ps1 contains a non-ASCII em-dash ("Write-Warning
\"[DEPRECATED] validate-phase1.ps1 — Phase 1 migration already validated. Use
validate-task-v2.js directly.\"") which triggers PSUseBOMForUnicodeEncodedFile;
fix by either saving validate-phase1.ps1 as UTF-8 with BOM so the em-dash is
encoded correctly, or replace/remove the em-dash (e.g., use a plain hyphen or
remove it) in the Write-Warning message to keep the file ASCII-only.


$tasks = @(
'dev-develop-story.md',
'create-next-story.md',
Expand Down
Loading
Loading