-
Notifications
You must be signed in to change notification settings - Fork 1
Test section expand collapse #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sprint-17-staging
Are you sure you want to change the base?
Conversation
kaladay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor to remove out WIP commits like:
WIP - show more button clicked successfully code clean up needed
- Code clean up per PR suggestions. Link: #522
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
|
|
||
| const container = toggleBtn.closest('.research-areas') as HTMLElement | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over this closer and I think this type to null is not necessary and should be removed because of the if (!container) return; after that.
The | null should be removed.
const container = toggleBtn.closest('.research-areas') as HTMLElement;
Description
This feature enables the expand collapse feature in the research areas in an Organization.
Type of change
Testing Procedures
Verified this feature works on local.


Click link: To see more click on Show more link.
Click link: To see the collapsed version, click Show less link.