Open
Conversation
uyarn
reviewed
Mar 8, 2024
| /** | ||
| * self-defined import icon component from tdesign-icons-vue-next | ||
| */ | ||
| iconComponents?: TDesignIconComponent[]; |
Contributor
There was a problem hiding this comment.
感觉这里不用新增吧 有点容易误解 iconInclude和iconExclude 就可以满足了 resolveIcons 应该就是要不要resolve icon这个包的
Member
Author
There was a problem hiding this comment.
我理解是原来三个参数只处理图标导入，不处理其他
Contributor
There was a problem hiding this comment.
resolveIcons 本应就包括这两个组件了 是实现缺了 可以再改下描述 而且通过原来的API完全可以满足不导入这两个或者需要这两个的需求 再新增API又是继续增加维护成本
Member
There was a problem hiding this comment.
同意UY的观点，确实API太多太容易混乱了，除非有什么必须区分的理由
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.