Open
Conversation
9114b71 to
2f3e501
Compare
There was a problem hiding this comment.
PR Overview
This PR implements support for the tdesign-vue repository by adding a new GitHub Actions workflow and updating git and trigger utilities to handle Vue‐specific PR processes. Key changes include:
- Introducing a new workflow (.github/workflows/test-tdesign-vue.yaml) for pull requests targeting develop.
- Renaming and updating the git configuration function and adding new SSH configuration logic.
- Extending trigger and git utility functions to accommodate repository-specific operations and fork PR handling.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/test-tdesign-vue.yaml | Adds a workflow to test tdesign-vue PRs |
| src/utils.ts | Renames git config function to setGitGlobalConfig and adds SSH config |
| src/utils/trigger.ts | Updates import and switch-case mappings for trigger context handling |
| src/utils/git.ts | Adds helper functions for branch checkout, PR checkout, and remote setup |
| action.yml | Updates token input description and makes it required |
| src/index.ts | Updates the entry point to use the new git config function |
| src/tdesign/vue.ts | Introduces Vue-specific update logic for handling PR operations |
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
| mkdirSync(`${sshPath}`, { mode: 0o700 }) | ||
| writeFileSync(`${sshPath}/id_rsa`, token, { mode: 0o600 }) | ||
| await exec('ls', ['-al', sshPath]) | ||
| await exec(`ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts`) |
There was a problem hiding this comment.
Using shell redirection (>>) in exec may not work as expected since exec does not spawn a shell by default. Consider using a shell wrapper (e.g., exec('sh', ['-c', 'ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts'])) or handling output redirection explicitly.
Suggested change
| await exec(`ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts`) | |
| await exec('sh', ['-c', 'ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts']) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.