Added an unprogrammed mode to fpga Processor #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… programming the FPGA (useful for gathering experimental data)
Collaborator
Author
|
Closed because I found bug where the user must have the given serial port open, even in unprogrammed mode. Fixing now. |
…n unprogrammed mode
Collaborator
Author
|
Reopened this PR since I fixed the bug where users must specify a valid serial port, even when only using unprogrammed mode. Everything should be working as intended now. I added an empty default value to |
keegandent
reviewed
Jan 29, 2026
| self, | ||
| target: str, | ||
| interface: Serial | str, | ||
| interface: Serial | str = "", |
Member
There was a problem hiding this comment.
My only preference is I don't like the empty string pattern. I think we could have
Suggested change
| interface: Serial | str = "", | |
| interface: Serial | str | None = None, |
And then later probably have
if(interface is None):
# none case here
...
elif(isinstance(interface, str)):
...
elif(isinstance(interface, Serial)):
...
else:
RuntimeError(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature to solve Issue #53