Skip to content

fix: replace blocking sleep with async sleep and fix file handle leak #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuzilin merged 1 commit into from
Jan 4, 2026
Merged

fix: replace blocking sleep with async sleep and fix file handle leak #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slime/ray/rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def check_weights(self, action: str):
def _get_rollout_data(self, rollout_id):
if self.args.load_debug_rollout_data:
data = torch.load(
open(self.args.load_debug_rollout_data.format(rollout_id=rollout_id), "rb"),
self.args.load_debug_rollout_data.format(rollout_id=rollout_id),
weights_only=False,
)["samples"]
data = [Sample.from_dict(sample) for sample in data]
Expand Down
4 changes: 2 additions & 2 deletions slime/router/middleware_hub/radix_tree_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import asyncio
import json
from time import sleep

from fastapi.responses import JSONResponse
from starlette.middleware.base import BaseHTTPMiddleware
Expand Down Expand Up @@ -108,7 +108,7 @@ async def dispatch(self, request: Request, call_next):
):
break
# await 30 seconds for aborted responses
sleep(30)
await asyncio.sleep(30)

if isinstance(response_data, dict) and "text" in response_data and "output_ids" in response_data:
generated_text = response_data["text"]
Expand Down