Skip to content

Conversation

@MaartenS11
Copy link
Member

In some cases, value_repr is called on Global struct pointers instead of StackValue pointers, causing a compilation error when enabling logging. This PR fixes that by getting the associated StackValue pointer from the global.

@MaartenS11 MaartenS11 requested a review from tolauwae December 18, 2025 14:16
@MaartenS11 MaartenS11 changed the title Fix logging causing compilation errors Fix compilation errors when using logging with the new globals Dec 18, 2025
Copy link
Member

@tolauwae tolauwae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MaartenS11 MaartenS11 merged commit 8479bb8 into main Dec 18, 2025
22 of 23 checks passed
@MaartenS11 MaartenS11 deleted the fix/globals-logging branch December 18, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants