fix(command): fix incorrect param check for Parser.register#236
Merged
TWT233 merged 1 commit intoTWT233:mainfrom Aug 29, 2024
Merged
fix(command): fix incorrect param check for Parser.register#236TWT233 merged 1 commit intoTWT233:mainfrom
TWT233 merged 1 commit intoTWT233:mainfrom
Conversation
Change the requirements from non-async and only one str param, to regardless of async and either (str) or (Message, Client, str) param types. Since this feature was broken, there would be no incompatibilities. Closes #235
Contributor
|
Should we let pylint ignore the problems? |
hank9999
added a commit
to hank9999/khl.py
that referenced
this pull request
Nov 19, 2024
hank9999
added a commit
to hank9999/khl.py
that referenced
this pull request
Nov 19, 2024
Owner
|
Would be better to fix since looks kinda easy to cleanup?
On Nov 20, 2024, at 06:06, hank9999 ***@***.***> wrote:
Should we let pylint ignore the problems?
khl/command/parser.py:32:16: W0613: Unused argument 'msg' (unused-argument)
khl/command/parser.py:32:30: W0613: Unused argument 'client' (unused-argument)
khl/command/parser.py:2:0: W06[11]: Unused import asyncio (unused-import)
—
Reply to this email directly, view it on GitHub<#236 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWDZFFHQAB4PGV2MKZ77I32BOY7LAVCNFSM6AAAAABJXCXIY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWHA2DSNBXGQ>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the requirements from non-async and only one str param, to regardless of async and either (str) or (Message, Client, str) param types. Since this feature was broken, there would be no incompatibilities.
Closes #235