-
Notifications
You must be signed in to change notification settings - Fork 30
[FEATURE] Add support for TYPO3 13LTS #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Starkmann
wants to merge
17
commits into
main
Choose a base branch
from
feature/typo3-13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Configuration/TCA/Overrides/tt_content.php
Pull Request Test Coverage Report for Build 15096663207Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
cause we use TYPO3\CMS\Install\Updates\AbstractListTypeToCTypeUpdate. We had to take care about nikic/php-parser, cause this package is needed in different Versions for typo3/cms-install and ssch/typo3-rector.
now we can use rector with php-parser 5.4.0. Tests are running fine in both TYPO3 Versions.
Contributor
|
Let's do those tasks as pre-patches first:
I've also added them as sub-tasks to #1641. |
we need to update some packages to make rector, phpstan work. # Conflicts: # composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.