Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
v1.0.4upgrade handler that enables theed25519precompile (0x...08f3) inActiveStaticPrecompilesand it removesv1.0.3upgrade handler from the registered upgrades list.The
v1.0.3handler was included in the CometBFT patched binary (silent-roll). Submitting av1.0.3upgrade proposal while the handler is already in the running binary triggers a "BINARY UPDATED BEFORE TRIGGER" panic. Removing it and introducing v1.0.4 avoids this conflict.Behavior
v1.0.3was never executed on-chain.v1.0.4replaces it, allowing the upgrade proposal to proceed without the conflict. Handler activatesed25519precompile for the first time.v1.0.3already executed (ed25519 already active).v1.0.4can be executed on testnet for version consistency but has no functional effect.Testing
Tested locally