-
Notifications
You must be signed in to change notification settings - Fork 4
feat: date picker core #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bart-krakowski
wants to merge
176
commits into
TanStack:v0
Choose a base branch
from
bart-krakowski:feat/date-picker-core
base: v0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: date picker core #11
bart-krakowski
wants to merge
176
commits into
TanStack:v0
from
bart-krakowski:feat/date-picker-core
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore/vitest config
docs: architecture
docs: readme
docs: add the choosing-a-date-time-handling-solution adr
test: refactor tests for the parse util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatePicker Core
Summary
This RFC proposes the creation of a DatePickerCore class that extends the CalendarCore class to include additional functionalities for managing date selection. This includes single-date, multiple-date, and range selection modes. The DatePickerCore is designed for use in various date picker applications where precise date management and selection are required.
Motivation
The motivation behind this RFC is to provide a flexible and efficient core for date picker applications, enabling consistent and simplified management of date selection functionalities. By extending CalendarCore, this class leverages existing calendar functionalities while adding robust support for date selection, ensuring it can handle a variety of use cases such as single-date, multiple-date, and range selection.
The DatePickerCore class extends CalendarCore to provide additional functionalities for managing date selection, including single-date, multiple-date, and range selection modes. This class is designed to be used in various date picker applications where precise date management and selection are required.
Parameters
weekStartsOn?: numberevents?: TEvent[]viewMode: ViewModelocale?: Parameters<Temporal.PlainDate['toLocaleString']>['0']minDate?: Temporal.PlainDatemaxDate?: Temporal.PlainDateselectedDates?: Temporal.PlainDate[]multiple?: booleanrange?: booleanReturns
getSelectedDates(): Temporal.PlainDate[]selectDate(date: Temporal.PlainDate): voidgetDaysWithEvents(): Array<Day<TEvent>>getDaysNames(): string[]changeViewMode(newViewMode: ViewMode): voidgoToPreviousPeriod(): voidgoToNextPeriod(): voidgoToCurrentPeriod(): voidgoToSpecificPeriod(date: Temporal.PlainDate): voidupdateCurrentTime(): voidgetEventProps(id: Event['id']): { style: CSSProperties } | nullgetCurrentTimeMarkerProps(): { style: CSSProperties; currentTime: string | undefined }groupDaysBy(props: Omit<GroupDaysByProps<TEvent>, 'weekStartsOn'>): (Day<TEvent> | null)[][]Example Usage