Update record title translation in AuditsRelationManager#60
Open
zvizvi wants to merge 1 commit intoTappNetwork:4.xfrom
Open
Update record title translation in AuditsRelationManager#60zvizvi wants to merge 1 commit intoTappNetwork:4.xfrom
zvizvi wants to merge 1 commit intoTappNetwork:4.xfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| return $table | ||
| ->recordTitle(fn (Model $record): string => 'Audit') | ||
| ->recordTitle(fn(Model $record): string => trans('filament-auditing::filament-auditing.table.heading')) |
There was a problem hiding this comment.
Record title incorrectly uses plural translation key
Low Severity
The recordTitle callback now uses trans('filament-auditing::filament-auditing.table.heading') which returns "Audits" (plural), but recordTitle is used for individual record references in modals and action confirmations. The original singular "Audit" was semantically correct. Using the plural form will produce grammatically incorrect UI text like "View Audits" when viewing a single record. The table.heading key is appropriate for getTitle() (table header) but not for individual record titles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Details of the feature / fix this PR addresses
Note
Improves localization of the audits table record title.
AuditsRelationManager,table()->recordTitlenow usestrans('filament-auditing::filament-auditing.table.heading')instead of the hardcoded'Audit'Written by Cursor Bugbot for commit a375d30. This will update automatically on new commits. Configure here.