Open
Conversation
Tarcaye
force-pushed
the
feature/basket-informations
branch
2 times, most recently
from
ee7b8f0 to
e5d5fe5
Compare
Tarcaye
force-pushed
the
feature/basket-informations
branch
from
e5d5fe5 to
3f5b798
Compare
| public class BasketInformations { | ||
|
|
||
| // The product of the basket | ||
| static HashMap<String, Integer> map = new HashMap<String, Integer>(); |
There was a problem hiding this comment.
Naming can be better, what is this a map of?
| // The fact that the basket has promo code | ||
| private static boolean codeDePromotion = false; | ||
|
|
||
| public void addProductToBasket(String product, Integer price, boolean isPromoCode) { |
There was a problem hiding this comment.
price better be double to accomodate decimals.
|
|
||
| public void addProductToBasket(String product, Integer price, boolean isPromoCode) { | ||
| if (isPromoCode) { | ||
| codeDePromotion = true; |
There was a problem hiding this comment.
should we convey to callers that adding to basket failed or was not done?
| map.clear(); | ||
| } | ||
|
|
||
| public boolean isBasketContains(String produit) { |
There was a problem hiding this comment.
spell check, produit -> product?
|
|
||
| public boolean isBasketContains(String produit) { | ||
| boolean found = false; | ||
| for (String s : map.keySet()) { |
There was a problem hiding this comment.
why not directly do map,get ?
| public boolean isBasketContains(String produit) { | ||
| boolean found = false; | ||
| for (String s : map.keySet()) { | ||
| if (s == produit) found = true; |
There was a problem hiding this comment.
return true if found, dont need to continue the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.