-
Notifications
You must be signed in to change notification settings - Fork 0
컬렉션 API 연동 #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
컬렉션 API 연동 #272
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
68ffc50
style/#269: Apply SwiftLint autocorrect
github-actions[bot] 5ec2859
feat/#269: dev 병합
pinocchio22 f3c6a7a
feat/#269: 북마크를 여러 컬렉션에 저장
pinocchio22 75d7960
chore/#269: swiftLint 수정
pinocchio22 c5e32ec
feat/#269: 컬렉션 수정 기능 추가(북마크 / 이름)
pinocchio22 195147c
feat/#269: 컬렉션 삭제 기능 추가
pinocchio22 40be770
feat/#269: 컬렉션-북마크 추가 API 변경
pinocchio22 58598f3
feat/#269: 컬렉션탭 sortFilter 추가
pinocchio22 4f47142
style/#269: Apply SwiftLint autocorrect
github-actions[bot] 5999c7e
fix/#269: DomainHTTPError 삭제
pinocchio22 34dd40d
fix/#269: guard문 수정
pinocchio22 244164b
Merge branch 'feat/#269-CollectionAPI' of github.com:Team-Maple/MLS-i…
pinocchio22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
MLS/Domain/Domain/UseCaseImpl/Collection/AddBookmarksToCollectionUseCaseImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // import DomainInterface | ||
| // | ||
| // import RxSwift | ||
| // | ||
| // public final class AddBookmarksToCollectionUseCaseImpl: AddBookmarksToCollectionUseCase { | ||
| // private let repository: CollectionAPIRepository | ||
| // | ||
| // public init(repository: CollectionAPIRepository) { | ||
| // self.repository = repository | ||
| // } | ||
| // | ||
| // public func execute(collectionId: Int, bookmarkIds: [Int]) -> Completable { | ||
| // return repository.addBookmarksToCollection(collectionId: collectionId, bookmarkIds: bookmarkIds) | ||
| // } | ||
| // } | ||
pinocchio22 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
14 changes: 14 additions & 0 deletions
14
MLS/Domain/Domain/UseCaseImpl/Collection/AddCollectionAndBookmarkUseCaseImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import DomainInterface | ||
| import RxSwift | ||
|
|
||
| public final class AddCollectionAndBookmarkUseCaseImpl: AddCollectionAndBookmarkUseCase { | ||
| private let repository: CollectionAPIRepository | ||
|
|
||
| public init(repository: CollectionAPIRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| public func execute(collectionIds: [Int], bookmarkIds: [Int]) -> Completable { | ||
| return repository.addCollectionAndBookmark(collectionIds: collectionIds, bookmarkIds: bookmarkIds) | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
MLS/Domain/Domain/UseCaseImpl/Collection/AddCollectionsToBookmarkUseCaseImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // import DomainInterface | ||
| // import RxSwift | ||
| // | ||
| // public final class AddCollectionsToBookmarkUseCaseImpl: AddCollectionsToBookmarkUseCase { | ||
| // private let repository: CollectionAPIRepository | ||
| // | ||
| // public init(repository: CollectionAPIRepository) { | ||
| // self.repository = repository | ||
| // } | ||
| // | ||
| // public func execute(bookmarkId: Int, collectionIds: [Int]) -> Completable { | ||
| // return repository.addCollectionsToBookmark(bookmarkId: bookmarkId, collectionIds: collectionIds) | ||
| // } | ||
| // } | ||
pinocchio22 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
15 changes: 15 additions & 0 deletions
15
MLS/Domain/Domain/UseCaseImpl/Collection/DeleteCollectionUseCaseImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import DomainInterface | ||
|
|
||
| import RxSwift | ||
|
|
||
| public final class DeleteCollectionUseCaseImpl: DeleteCollectionUseCase { | ||
| private let repository: CollectionAPIRepository | ||
|
|
||
| public init(repository: CollectionAPIRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| public func execute(collectionId: Int) -> Completable { | ||
| return repository.deleteCollection(collectionId: collectionId) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
MLS/Domain/Domain/UseCaseImpl/Collection/SetCollectionUseCaseImpl.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import DomainInterface | ||
|
|
||
| import RxSwift | ||
|
|
||
| public final class SetCollectionUseCaseImpl: SetCollectionUseCase { | ||
| private let repository: CollectionAPIRepository | ||
|
|
||
| public init(repository: CollectionAPIRepository) { | ||
| self.repository = repository | ||
| } | ||
|
|
||
| public func execute(collectionId: Int, name: String) -> Completable { | ||
| return repository.setCollectionName(collectionId: collectionId, name: name) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
MLS/Domain/DomainInterface/UseCase/Collection/AddBookmarksToCollectionUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // import RxSwift | ||
| // | ||
| // public protocol AddBookmarksToCollectionUseCase { | ||
| // func execute(collectionId: Int, bookmarkIds: [Int]) -> Completable | ||
| // } | ||
pinocchio22 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
5 changes: 5 additions & 0 deletions
5
MLS/Domain/DomainInterface/UseCase/Collection/AddCollectionAndBookmarkUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import RxSwift | ||
|
|
||
| public protocol AddCollectionAndBookmarkUseCase { | ||
| func execute(collectionIds: [Int], bookmarkIds: [Int]) -> Completable | ||
| } |
5 changes: 5 additions & 0 deletions
5
MLS/Domain/DomainInterface/UseCase/Collection/AddCollectionsToBookmarkUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // import RxSwift | ||
| // | ||
| // public protocol AddCollectionsToBookmarkUseCase { | ||
| // func execute(bookmarkId: Int, collectionIds: [Int]) -> Completable | ||
| // } | ||
pinocchio22 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
5 changes: 5 additions & 0 deletions
5
MLS/Domain/DomainInterface/UseCase/Collection/DeleteCollectionUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import RxSwift | ||
|
|
||
| public protocol DeleteCollectionUseCase { | ||
| func execute(collectionId: Int) -> Completable | ||
| } |
2 changes: 1 addition & 1 deletion
2
MLS/Domain/DomainInterface/UseCase/Collection/FetchCollectionListUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import RxSwift | ||
|
|
||
| public protocol FetchCollectionListUseCase { | ||
| func execute() -> Observable<[CollectionResponse]> | ||
| func execute(sort: SortType?) -> Observable<[CollectionResponse]> | ||
| } |
5 changes: 5 additions & 0 deletions
5
MLS/Domain/DomainInterface/UseCase/Collection/SetCollectionUseCase.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import RxSwift | ||
|
|
||
| public protocol SetCollectionUseCase { | ||
| func execute(collectionId: Int, name: String) -> Completable | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주석 처리된
addBookmarksToCollection및addCollectionsToBookmark함수가 있습니다. 현재 사용되지 않는 코드라면 가독성과 유지보수성 향상을 위해 삭제하는 것을 고려해 보세요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 수정 예정