-
Notifications
You must be signed in to change notification settings - Fork 0
내부 테스트 피드백 수정 #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
내부 테스트 피드백 수정 #275
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
deb46e3
fix/#273: 검색결과 count 순서 수정 (Map <-> NPC)
pinocchio22 dfedcc3
refactor/#273: 북마크 아이콘 교체
pinocchio22 9d20dfc
refactor/#273: clean code
pinocchio22 09806f9
fix/#273: 검색시 키보드 엔터 사용 가능
pinocchio22 3d33911
fix/#273: 리스트 북마크 아이콘 추가
pinocchio22 0c0b197
fix/#273: 검색화면 진입시 텍스트필드 포커싱
pinocchio22 211d09d
fix/#273: 셀 재사용문제 해결
pinocchio22 c9c8213
fix/#273: 도감 리스트 탑 마진 수정
pinocchio22 969bb71
fix/#273: PinchMapView 이미지 연결
pinocchio22 3acad17
fix/#273: 몬스터 태그뷰 중첩 이슈 수정
pinocchio22 16f6beb
fix/#273: 퀘스트 상세 Lv 텍스트 수정
pinocchio22 7abef8c
fix/#273: 맵 이미지 및 출현맵 텍스트 간격 수정
pinocchio22 44226e2
fix/#273: 맵 상세 이미지 로딩 이미지 사이즈 수정
pinocchio22 32f8a25
fix/#273: 퀘스트 메인 텍스트 제약 수정
pinocchio22 5daf861
fix/#273: 아이템 상세 페이지 공격속도 데이터 추가
pinocchio22 2e43c72
fix/#273: 상점판매가 number 포맷으로 수정
pinocchio22 c4dbaac
fix/#273: CardView 내부 가로 제약 수정
pinocchio22 e9d21ad
style/#273: Apply SwiftLint autocorrect
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,4 +43,12 @@ public extension ItemImageView { | |
| imageView.image = image | ||
| self.backgroundColor = backgroundColor | ||
| } | ||
|
|
||
| func setMapImage(image: UIImage?, backgroundColor: UIColor) { | ||
| setImage(image: image, backgroundColor: backgroundColor) | ||
| imageView.snp.remakeConstraints { make in | ||
| make.center.equalToSuperview() | ||
| make.size.equalTo(40) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ntation/DesignSystem/DesignSystem/Resource/Image.xcassets/bookmark.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...esignSystem/DesignSystem/Resource/Image.xcassets/bookmark.imageset/bookmark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 0 additions & 3 deletions
3
...System/DesignSystem/Resource/Image.xcassets/bookmark.imageset/bookmark_true.svg
This file was deleted.
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
...n/DesignSystem/DesignSystem/Resource/Image.xcassets/bookmarkBorder.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "bookmark_border.svg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
...esignSystem/Resource/Image.xcassets/bookmarkBorder.imageset/bookmark_border.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imageView의 접근 제어 수준을public으로 변경하셨는데, 캡슐화를 위해private으로 유지하는 것이 좋습니다.imageView의 속성을 외부에서 직접 변경하기보다는,CardList에 필요한 기능을 수행하는 메서드를 추가하여 노출하는 방식(예:setMapImage)을 사용하는 것이 더 안전하고 유지보수하기 좋은 코드 구조입니다. 외부에서imageView에 직접 접근해야 하는 특별한 이유가 없다면private으로 되돌리는 것을 고려해 보세요.