Skip to content

[refactor] 쿠키 정책 변경 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
win9-tech merged 1 commit into from
Feb 21, 2025
Merged

[refactor] 쿠키 정책 변경 #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/pickyfy/pickyfy/auth/filter/CustomLoginFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ private void setBody(String role, HttpServletResponse response) throws IOExcepti
private ResponseCookie createCookie(String name, String token, String path) {
return ResponseCookie.from(name, token)
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path(path)
.maxAge(Duration.ofMillis(Constant.COOKIE_EXPIRATION).getSeconds())
.build();
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/pickyfy/pickyfy/auth/handler/OAuth2SuccessHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public void onAuthenticationSuccess(HttpServletRequest request, HttpServletRespo
private ResponseCookie createCookie(String name, String token, String path) {
return ResponseCookie.from(name, token)
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path(path)
.maxAge(Duration.ofMillis(Constant.COOKIE_EXPIRATION).getSeconds())
.build();
Expand Down
16 changes: 8 additions & 8 deletions src/main/java/com/pickyfy/pickyfy/web/controller/AuthController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,16 @@ public ApiResponse<Boolean> isAuthenticated(
private void createCookie(HttpServletResponse response, AuthResponse token) {
ResponseCookie expiredAccessToken = ResponseCookie.from(ACCESS_TOKEN_COOKIE_NAME, token.accessToken())
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path("/")
.maxAge(Duration.ofMillis(Constant.COOKIE_EXPIRATION).getSeconds())
.build();

ResponseCookie expiredRefreshToken = ResponseCookie.from(REFRESH_TOKEN_COOKIE_NAME, token.refreshToken())
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path("/auth")
.maxAge(Duration.ofMillis(Constant.COOKIE_EXPIRATION).getSeconds())
.build();
Expand All @@ -83,16 +83,16 @@ private void createCookie(HttpServletResponse response, AuthResponse token) {
private void clearCookie(HttpServletResponse response) {
ResponseCookie expiredAccessToken = ResponseCookie.from(ACCESS_TOKEN_COOKIE_NAME, "")
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path("/")
.maxAge(0)
.build();

ResponseCookie expiredRefreshToken = ResponseCookie.from(REFRESH_TOKEN_COOKIE_NAME, "")
.httpOnly(true)
.secure(false)
.sameSite("Lax")
.secure(true)
.sameSite("None")
.path("/auth")
.maxAge(0)
.build();
Expand Down