Conversation
Closed
6 tasks
xjvmdutl
reviewed
Apr 26, 2025
| public void withdrawCrew(UUID crewId, CrewWithdrawalRequest request) { | ||
| Crew crew = findCrewById(crewId); | ||
| CrewMembers crewMembers = crew.getCrewMembers(); | ||
| crewMembers.withdraw(request.memberId(), request.participatingCrewTrips()); |
|
|
||
| private void validatePossibleWithdrawal(UUID memberId, List<CrewTrip> crewTrips) { | ||
| if (isLeader(memberId)) { | ||
| throw new ImpossibleWithdrawCrewException("크루 리더는 탈퇴할 수 없습니다."); |
Collaborator
There was a problem hiding this comment.
크루 리더가 탈퇴 시, 다른 사람에 크루 리더 요청 할 수 있도록 했던거 같은데.! 어떻게 처리하실지 문의 드려요!
Contributor
Author
There was a problem hiding this comment.
크루 리더를 먼저 위임해야 한다고 생각해서 별도의 이슈로 만들었어요 #36
pparkjs
reviewed
Apr 27, 2025
Contributor
pparkjs
left a comment
pparkjs
left a comment
There was a problem hiding this comment.
고생하셨습니다! 코맨트 남겨놓은 거 확인 부탁드릴게요
Comment on lines
+13
to
+14
| @Schema(description = "크루 ID") | ||
| UUID tripId, |
| import static com.retrip.crew.domain.CrewTrip.CrewTripType.EXCLUSION; | ||
|
|
||
| @Schema(description = "크루 여행") | ||
| public record CrewTrip( |
Contributor
There was a problem hiding this comment.
혹시 해당 CrewTrip을 탈퇴 Request에서 받던데 본인이 참여중인 크루 여행목록은 프론트에서 주는건가요?? 여행에서 가져오는게 아니라?
Contributor
Author
There was a problem hiding this comment.
API gateway에서 Trip 서비스로 요청해서 참여중인 크루 여행 목록을 받아오고
다시 Crew 서비스의 크루 탈퇴 API의 Request로 넘겨준다고 생각해서 설계했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 PR 타입 선택
아래 타입 중 해당하는 하나를 선택해 주세요. 반드시 하나만 선택해 주세요.
feat: 새로운 기능 추가📝 변경 사항 요약
변경 사항을 간단히 요약해 주세요.
🛠 관련 이슈
Resolves: #10
추가 설명 (선택 사항)
변경 사항에 대한 추가 설명을 작성해 주세요.