[Refactor] Hilt 완전 적용 및 멀티 모듈 구조 설정#120
Merged
tristanjung1006 merged 1 commit intomasterfrom Dec 28, 2025
Merged
Conversation
Phase 1: Hilt 완전 적용 - NetworkModule에 누락된 서비스 추가 (Create, Social, Notice, Record, FCM) - 모든 Repository에 @Inject @singleton 적용 - 모든 ViewModel을 @hiltviewmodel 패턴으로 마이그레이션 - ViewModelFactory 클래스 삭제 (7개 파일) - 모든 Fragment에 @androidentrypoint 적용 (30+ 파일) - Fragment에서 by viewModels() 델리게이트 사용으로 전환 Phase 2: 멀티 모듈 구조 설정 - build-logic Convention Plugins 생성 - Version Catalog (libs.versions.toml) 추가 - Core 모듈 생성: common, network, datastore, domain, data, designsystem - Feature 모듈 생성: home, social, record, mypage, onboarding, create, notice - app 모듈에 core 모듈 의존성 연결 버그 수정 - CreateService.kt 패키지명 오타 수정 - google-services.json 패키지명 오타 수정 - SigningConfig storeFile 누락 시 기본값 사용하도록 수정
|
Caution Review failedThe pull request is closed. 개요이 PR은 Android 프로젝트를 다중 모듈 아키텍처로 재구성하고 Hilt 기반 의존성 주입(DI)으로 마이그레이션합니다. 새로운 변경 사항
시퀀스 다이어그램sequenceDiagram
participant Fragment
participant Hilt as Hilt/DI Container
participant ViewModel as ViewModel<br/>(HiltViewModel)
participant Repository as Repository<br/>(`@Singleton`)
participant Service as Network Service<br/>(Retrofit)
participant NetworkClient as NetworkClient
Fragment->>Hilt: `@AndroidEntryPoint`<br/>by activityViewModels()
Hilt->>ViewModel: `@HiltViewModel` 생성<br/>의존성 주입
ViewModel->>Hilt: Repository 요청
Hilt->>Repository: `@Singleton`<br/>@Inject constructor
Repository->>Hilt: Service 요청
Hilt->>Service: `@Provides` 메서드<br/>@AuthRetrofit Retrofit
Service->>NetworkClient: getAuthClient()
NetworkClient-->>Service: Retrofit 인스턴스
Service-->>Repository: 네트워크 호출
Repository-->>ViewModel: Result<T> 반환
ViewModel-->>Fragment: LiveData/StateFlow 업데이트
예상 코드 리뷰 노력🎯 4 (복잡) | ⏱️ ~45분 관련 가능성이 있는 PR
추천 검토자
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (129)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Phase 1: Hilt 완전 적용
Phase 2: 멀티 모듈 구조 설정
버그 수정
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.