Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,54 @@
<Project>
<PropertyGroup>
<CSharpier_Check>false</CSharpier_Check>
<Configurations>Debug;Release;Debug-Windows;Debug-Linux;Debug-macOS;Release-Windows;Release-Linux;Release-macOS</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>

<!-- Platform-specific constants for Debug configurations -->
<PropertyGroup Condition="'$(Configuration)' == 'Debug-Windows'">
<DefineConstants>$(DefineConstants);DEBUG;TRACE;WINDOWS</DefineConstants>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<Optimize>false</Optimize>
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug-Linux'">
<DefineConstants>$(DefineConstants);DEBUG;TRACE;LINUX</DefineConstants>
<RuntimeIdentifier>linux-x64</RuntimeIdentifier>
<Optimize>false</Optimize>
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug-macOS'">
<DefineConstants>$(DefineConstants);DEBUG;TRACE;MACOS</DefineConstants>
<RuntimeIdentifier>osx-arm64</RuntimeIdentifier>
<Optimize>false</Optimize>
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
</PropertyGroup>

<!-- Platform-specific constants for Release configurations -->
<PropertyGroup Condition="'$(Configuration)' == 'Release-Windows'">
<DefineConstants>$(DefineConstants);TRACE;WINDOWS</DefineConstants>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>
<Optimize>true</Optimize>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Release-Linux'">
<DefineConstants>$(DefineConstants);TRACE;LINUX</DefineConstants>
<RuntimeIdentifier>linux-x64</RuntimeIdentifier>
<Optimize>true</Optimize>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Release-macOS'">
<DefineConstants>$(DefineConstants);TRACE;MACOS</DefineConstants>
<RuntimeIdentifier>osx-arm64</RuntimeIdentifier>
<Optimize>true</Optimize>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="CSharpier.MsBuild" Version="0.30.6">
<PrivateAssets>all</PrivateAssets>
Expand Down
8 changes: 4 additions & 4 deletions WheelWizard.sln
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ Global
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Debug|Any CPU.Build.0 = Debug|Any CPU
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Release|Any CPU.ActiveCfg = Release|Any CPU
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Release|Any CPU.Build.0 = Release|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Debug|Any CPU.Build.0 = Debug|Any CPU
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Debug|Any CPU.ActiveCfg = Debug-Windows|Any CPU
{DF73A1D9-B01E-4826-A0F3-A8105E66A931}.Debug|Any CPU.Build.0 = Debug-Windows|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Release|Any CPU.ActiveCfg = Release|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Release|Any CPU.Build.0 = Release|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C2A6FF37-2E6B-4683-A8DA-AD965E1CC55A}.Debug|Any CPU.Build.0 = Debug|Any CPU
EndGlobalSection
EndGlobal
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace WheelWizard.CustomDistributions;
public interface ICustomDistributionSingletonService
{
List<IDistribution> GetAllDistributions();

// FIXME: Abstract this reference away. A generic Distributions service kinda loses its purpose when you still have to reference a distribution by name (like done here)
// Instead you would want something like DistService.GetCurrentDistro()
// The rest of the application should not have to know what distribution is currently active.
Expand Down
2 changes: 1 addition & 1 deletion WheelWizard/Features/CustomDistributions/RetroRewind.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private async Task<OperationResult> DownloadAndExtractRetroRewind(ProgressWindow

//where all distributions are stored
var destinationParentDir = _fileSystem.DirectoryInfo.New(PathManager.RiivolutionWhWzFolderPath);

OperationResult? result = null;
try
{
Expand Down
Loading
Loading