Feature/solutions #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove solution code, add test scripts
…xercises Revert "Remove solution code, add test scripts"
Contributor
Author
|
Included two more exercises with solutions and changed the first exercise to include one of the other two to reduce code complexity. Also, I have updated the fake datasets to work with new tests. |
Reinoptland
suggested changes
Jun 10, 2019
| { id: 8, name: 'Misty', pokemonIds: [120, 121] }, | ||
| { id: 9, name: 'Ash', pokemonIds: [25, 1, 7, 6, 17, 12] }, | ||
| ] | ||
| { id: 1, name: "Brock", pokemonIds: [74, 95, 44] }, |
Contributor
There was a problem hiding this comment.
Brock does not have a Gloom! ;)
Contributor
Author
There was a problem hiding this comment.
Reeeeally? So it is true!! I need to know pokemons to pass this course :P haha.... I needed this in order to get some variety in my tests.. dunno if we can use someone else, or maybe make up a new trainer.
| }) | ||
| ); | ||
|
|
||
| return getTrainersAndGymsAndPokemons(gyms, trainers, pokemons) |
Contributor
There was a problem hiding this comment.
I think this is unreachable code ...
Contributor
Author
There was a problem hiding this comment.
Could be. I was making lots of tests I might have overlooked it. I'll check again.
Co-Authored-By: Rein Op 't Land <Reinoptland@gmail.com>
Co-Authored-By: Rein Op 't Land <Reinoptland@gmail.com>
Co-Authored-By: Rein Op 't Land <Reinoptland@gmail.com>
wearethefoos
force-pushed
the
feature/solutions
branch
from
457a425 to
9aa7382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new exercise should ask the students to return a list of trainers that have at least one pokemon.
These new trainer objects should also contain two additional variables, one that is an array and holds the list of their pokemons and the second one is an object that represents their gym.
This branch includes the solution as well as additional commenting for readability