-
Notifications
You must be signed in to change notification settings - Fork 74
SubscriBee - by Sofie, Sofia & Oskar #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Package scheduled emails when more than 1 email.
Moved icons to public + error handling default logo
Converted icons to .webp from png.
Opt out from email functionality
…e same .yml that updates reminder date.
fixed mobile layout errors in sublist
added test content
Removed non used fonts
Changed from export default to named export
email edit bug fix
Add sub bug fix
Remove scheduled mail when sub del
Sub add unchecked email box bug fix
Scheduled email sub del fix 2
Performancefix
Email checkbox bug fix
Email checkbox bug fix
import express and const router to make the delete work.
…mailScheduler to folder routes. Co-authored-by: Oskar Nordin <oskarnordin@users.noreply.github.com> Co-authored-by: Sofie <ssofiejohansson@users.noreply.github.com>
JennieDalgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hej! Do you mind trying again? I've both logged in and registered as a new user tonight and had no issues. Everything looks good backend too! Beeatrice is buzzing when the page is loading and render is extra slow sometimes but it should be working🐝🤞 |
JennieDalgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this project.
You have managed to do so many features, small animations, bigger features etc.
Your code is well structured, easy to follow and uses a good amount of comments to navigate thru the code base.
You project is approved with VG
| /** | ||
| * MongoEmailScheduler is responsible for managing the scheduling, batching, sending, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job with the documentation
| class MongoEmailScheduler { | ||
| constructor() { | ||
| this.isRunning = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a class?? If/when you have time, try to refactor this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oskarnordin Denna kan ju du kanske kika på om du har tid! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now fixed.

https://subscribee-project.netlify.app/