-
Notifications
You must be signed in to change notification settings - Fork 74
Final Project Submission - Christina #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
JennieDalgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks for the suggestion! I will work on the UX suggestion this weekend probably as I have a full week! Hope that's ok. About the generation of suggestions, it works fine for me so im not really sure what the issue is, maybe it was an onrender thing? If you try again now does it work? |
JennieDalgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Ah thats weird. Seems the image preview isn't showing either. I wont have time to look at it before Friday afternoon as i have my LIA and volunteering these few days. Hope that isn't an issue? But just in case, did you try and manage to generate on this account before? |
|
tried with different account, never managed to generate suggestions. |
|
ok so, i couldn't replicate the error you're getting at all, sent it to a friend, tried different browsers etc, live, local, etc. but i had a thought that maybe you were uploading an unsupported file format, so i added a check and stop for that just in case, i also added a bunch of logs to see if that tells me anything, can you also please walk me through your exact steps that got you there so what image you're using etc. |
|
This is the error I get when trying to generate suggestions: account: poppy@p.com |
|
Ok so I logged into your account (thanks for providing those details), and that image fails to generate for me too, but, I uploaded a different image and that worked. I'm pretty sure it has something to do with the image but I'm not sure what, if you have any ideas I'm open. But it could be size and/or resolution thing or a file tyoe somehow as I see it downloads as a .avif file but i dont know how that gets through the check. I will try limit that further, if you have details on the image or you are using, or ideas, that could help |
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this now since you have put in the work + it never fails for me. Good job! ⭐
|
Aw thank you both! ✨️ I'd love to figure out this bug though so if its still doing it for Jennie and you guys have time/ideas please let me know! |




No description provided.