Skip to content

Conversation

@Teester
Copy link
Owner

@Teester Teester commented Oct 18, 2025

Addresses #51. Moves the multiple classes in comparejsonld.py into separate files. Also moves getting the jsonld into a separate class from getting the shape for v1 of the api.

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.79%. Comparing base (4599728) to head (6d5df0f).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/compareproperties.py 94.06% 7 Missing ⚠️
src/comparestatements.py 95.38% 3 Missing ⚠️
src/utilities.py 95.08% 3 Missing ⚠️
src/getjsonld.py 95.23% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   92.17%   91.79%   -0.38%     
==========================================
  Files          11       15       +4     
  Lines        1418     1438      +20     
==========================================
+ Hits         1307     1320      +13     
- Misses        111      118       +7     
Files with missing lines Coverage Δ
src/app.py 75.71% <100.00%> (+0.35%) ⬆️
src/comparejsonld.py 93.42% <100.00%> (-0.89%) ⬇️
src/shape.py 91.47% <ø> (-2.90%) ⬇️
tests/test_jsonld.py 97.91% <100.00%> (+0.09%) ⬆️
tests/test_utilities.py 98.71% <100.00%> (ø)
src/getjsonld.py 95.23% <95.23%> (ø)
src/comparestatements.py 95.38% <95.38%> (ø)
src/utilities.py 95.08% <95.08%> (ø)
src/compareproperties.py 94.06% <94.06%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4599728...6d5df0f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…f a separate class to make it easier to work on and to make removing the v1 api easier if we decide to do that)
@sonarqubecloud
Copy link

@Teester Teester merged commit d79fe58 into master Oct 18, 2025
8 checks passed
@Teester Teester deleted the entityshape-51 branch October 18, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants