Skip to content

Fix user-after-free in network code #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mizarka wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Fix user-after-free in network code #666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions net/net-msg-buffers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,6 @@ void free_msg_buffers_chunk_internal (struct msg_buffers_chunk *C, struct msg_bu
__sync_fetch_and_add (&allocated_buffer_chunks, -1);
MODULE_STAT->allocated_buffer_bytes -= MSG_BUFFERS_CHUNK_SIZE;

memset (C, 0, sizeof (struct msg_buffers_chunk));
free (C);

int si = buffer_size_values - 1;
while (si > 0 && &ChunkHeaders[si-1] != CH) {
si--;
Expand All @@ -304,7 +301,9 @@ void free_msg_buffers_chunk_internal (struct msg_buffers_chunk *C, struct msg_bu
}

free_mp_queue (C->free_block_queue);
C->free_block_queue = NULL;

memset (C, 0, sizeof (struct msg_buffers_chunk));
free (C);
}


Expand Down