Do not block calling queue with IO operations of SignalCache#101
Open
mrackwitz wants to merge 1 commit intoTelemetryDeck:mainfrom
Open
Do not block calling queue with IO operations of SignalCache#101mrackwitz wants to merge 1 commit intoTelemetryDeck:mainfrom
SignalCache#101mrackwitz wants to merge 1 commit intoTelemetryDeck:mainfrom
Conversation
`SignalCache` used to dispatch synchronously instead of asynchronously to its concurrent queue for the IO operations of loading the cache and backing up the cache to file system which are typically done on app launch and when the app is sent to background respectively. Given how these functions are called, these would be typically blocking the main thread.
Contributor
Author
|
Actually, I just realized that the calling code in |
1 task
Jeehut
approved these changes
Dec 2, 2024
Contributor
Jeehut
left a comment
Jeehut
left a comment
There was a problem hiding this comment.
These changes look good to me. But what exactly do you mean with the NSTimer blocking right now? I'm not sure if I fully understand, can you please elaborate? Deos that mean your PR wouldn't solve your issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignalCacheused to dispatch synchronously instead of asynchronously to its concurrent queue for the I/O operations of loading the cache and backing up the cache to file system which are typically done on app launch and when the app is sent to background respectively. Given how these functions are called, these would be typically blocking the main thread.