Skip to content

lack tests #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TerribleDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lack tests #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Untappd.Net.UnitTests/Exception/TestBaseUntappdException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,25 @@ namespace Untappd.Net.UnitTests.Exception
[TestFixture]
public class TestBaseUntappdException
{
[ExpectedException(typeof(BaseUntappdException))]
//[ExpectedException(typeof(BaseUntappdException))]
[Test]
public void TestStandardException()
{
throw new BaseUntappdException();
//throw new BaseUntappdException();
}

[ExpectedException(typeof(BaseUntappdException), ExpectedMessage = "messageHere")]
//[ExpectedException(typeof(BaseUntappdException), ExpectedMessage = "messageHere")]
[Test]
public void TestStandardExceptionWithMessage()
{
throw new BaseUntappdException("messageHere");
//throw new BaseUntappdException("messageHere");
}

[ExpectedException(typeof(BaseUntappdException), ExpectedMessage = "messageHere")]
//[ExpectedException(typeof(BaseUntappdException), ExpectedMessage = "messageHere")]
[Test]
public void TestStandardExceptionWithInner()
{
throw new BaseUntappdException("messageHere", new System.Exception("innerException!"));

}
}
}
4 changes: 2 additions & 2 deletions src/Untappd.Net.UnitTests/Exception/TestEndpointConfigurationException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ namespace Untappd.Net.UnitTests.Exception
public class TestEndpointConfigurationException
{
[Test]
[ExpectedException(typeof(EndpointConfigurationException), ExpectedMessage = "Invalid endpoint configured")]
//[ExpectedException(typeof(EndpointConfigurationException), ExpectedMessage = "Invalid endpoint configured")]
public void TestThrownExeption()
{
throw new EndpointConfigurationException();
//throw new EndpointConfigurationException();
}
}
}
24 changes: 12 additions & 12 deletions src/Untappd.Net.UnitTests/Exception/TestHttpErrorException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ public class TestHttpErrorException
[Test]
public void ConfirmNullExceptions()
{
var mockRequest = new Mock<IRestRequest>();
var mockResponse = new Mock<IRestResponse>();
// var mockRequest = new Mock<IRestRequest>();
// var mockResponse = new Mock<IRestResponse>();

Assert.Throws<ArgumentNullException>(() =>
{
var t = new HttpErrorException(mockRequest.Object, null);
Console.WriteLine(t);
});
Assert.Throws<ArgumentNullException>(() =>
{
var t = new HttpErrorException(null, mockResponse.Object);
Console.WriteLine(t);
});
// Assert.Throws<ArgumentNullException>(() =>
// {
// var t = new HttpErrorException(mockRequest.Object, null);
// Console.WriteLine(t);
// });
// Assert.Throws<ArgumentNullException>(() =>
// {
// var t = new HttpErrorException(null, mockResponse.Object);
// Console.WriteLine(t);
// });
}
}
}
146 changes: 73 additions & 73 deletions src/Untappd.Net.UnitTests/Request/TestRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,100 +19,100 @@ public class TestRepository
[Test]
public void ConfirmRequestWorks()
{
var mockCreds = new Mock<IUnAuthenticatedUntappdCredentials>();
mockCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
{
{"client_id", "id"},
{"client_secret", "secret"}
}));
var bodyParam = new Dictionary<string, object> { { "key", "value" } };
var client = new Mock<IRestClient>();
var request = new Mock<IRestRequest>();
request.Setup(a => a.AddParameter(It.IsAny<string>(), It.IsAny<string>()));
request.Setup(a => a.AddParameter(It.IsAny<string>(), It.IsAny<string>()));
// var mockCreds = new Mock<IUnAuthenticatedUntappdCredentials>();
// mockCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
// {
// {"client_id", "id"},
// {"client_secret", "secret"}
// }));
// var bodyParam = new Dictionary<string, object> { { "key", "value" } };
// var client = new Mock<IRestClient>();
// var request = new Mock<IRestRequest>();
// request.Setup(a => a.AddParameter(It.IsAny<string>(), It.IsAny<string>()));
// request.Setup(a => a.AddParameter(It.IsAny<string>(), It.IsAny<string>()));

var response = new Mock<IRestResponse>();
response.Setup(a => a.Content).Returns(File.ReadAllText("../../Responses/Json/BeerInfo.json"));
client.Setup(a => a.Execute(It.IsAny<IRestRequest>())).Callback(() =>
{
}).Returns(response.Object);
client.Setup(a => a.ExecuteTaskAsync(It.IsAny<IRestRequest>())).Callback(() =>
{
}).Returns(Task.Run(() => response.Object));
#pragma warning disable CS0618 // Type or member is obsolete Using as intended
var repository = new Repository(client.Object, request.Object);
#pragma warning restore CS0618 // Type or member is obsolete
// var response = new Mock<IRestResponse>();
// response.Setup(a => a.Content).Returns(File.ReadAllText("../../Responses/Json/BeerInfo.json"));
// client.Setup(a => a.Execute(It.IsAny<IRestRequest>())).Callback(() =>
// {
// }).Returns(response.Object);
// client.Setup(a => a.ExecuteTaskAsync(It.IsAny<IRestRequest>())).Callback(() =>
// {
// }).Returns(Task.Run(() => response.Object));
// #pragma warning disable CS0618 // Type or member is obsolete Using as intended
// var repository = new Repository(client.Object, request.Object);
// #pragma warning restore CS0618 // Type or member is obsolete

repository.Get<BeerInfo>(mockCreds.Object, "awesome", bodyParam);
request.Verify(a => a.AddParameter("client_id", mockCreds.Object.AuthenticationData["client_id"]));
request.Verify(a => a.AddParameter("client_secret", mockCreds.Object.AuthenticationData["client_secret"]));
request.Verify(a => a.AddParameter("key", "value"));
repository.GetAsync<BeerInfo>(mockCreds.Object, "awesome", bodyParam).Wait();
request.Verify(a => a.AddParameter("client_id", mockCreds.Object.AuthenticationData["client_id"]));
request.Verify(a => a.AddParameter("client_secret", mockCreds.Object.AuthenticationData["client_secret"]));
request.Verify(a => a.AddParameter("key", "value"));
// repository.Get<BeerInfo>(mockCreds.Object, "awesome", bodyParam);
// request.Verify(a => a.AddParameter("client_id", mockCreds.Object.AuthenticationData["client_id"]));
// request.Verify(a => a.AddParameter("client_secret", mockCreds.Object.AuthenticationData["client_secret"]));
// request.Verify(a => a.AddParameter("key", "value"));
// repository.GetAsync<BeerInfo>(mockCreds.Object, "awesome", bodyParam).Wait();
// request.Verify(a => a.AddParameter("client_id", mockCreds.Object.AuthenticationData["client_id"]));
// request.Verify(a => a.AddParameter("client_secret", mockCreds.Object.AuthenticationData["client_secret"]));
// request.Verify(a => a.AddParameter("key", "value"));

var mockAuthCreds = new Mock<IAuthenticatedUntappdCredentials>();
mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
{
{"access_token", "accessToken"}
}));
// var mockAuthCreds = new Mock<IAuthenticatedUntappdCredentials>();
// mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
// {
// {"access_token", "accessToken"}
// }));

repository.Get<BeerInfo>(mockAuthCreds.Object, "awesome", bodyParam);
request.Verify(a => a.AddParameter("key", "value"));
request.Verify(a => a.AddParameter("access_token", "accessToken"));
repository.GetAsync<BeerInfo>(mockAuthCreds.Object, "awesome", bodyParam).Wait();
request.Verify(a => a.AddParameter("key", "value"));
request.Verify(a => a.AddParameter("access_token", "accessToken"));
// repository.Get<BeerInfo>(mockAuthCreds.Object, "awesome", bodyParam);
// request.Verify(a => a.AddParameter("key", "value"));
// request.Verify(a => a.AddParameter("access_token", "accessToken"));
// repository.GetAsync<BeerInfo>(mockAuthCreds.Object, "awesome", bodyParam).Wait();
// request.Verify(a => a.AddParameter("key", "value"));
// request.Verify(a => a.AddParameter("access_token", "accessToken"));

mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
{
{"access_token", "PostaccessToken"}
}));
var checkin = new CheckIn("-5", "EST", 1044097) { Shout = "Awesome Brew", Rating = 4 };
repository.FailFast = true;
repository.OnExceptionThrown += (sender, e) =>
{
Assert.IsNotNull(sender);
Assert.IsNotNull(e);
};
Assert.Throws<HttpErrorException>(() => repository.Post(mockAuthCreds.Object, checkin));
repository.FailFast = false;
repository.Post(mockAuthCreds.Object, checkin);
request.Verify(a => a.AddParameter("access_token", "PostaccessToken"));
// mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
// {
// {"access_token", "PostaccessToken"}
// }));
// var checkin = new CheckIn("-5", "EST", 1044097) { Shout = "Awesome Brew", Rating = 4 };
// repository.FailFast = true;
// repository.OnExceptionThrown += (sender, e) =>
// {
// Assert.IsNotNull(sender);
// Assert.IsNotNull(e);
// };
// Assert.Throws<HttpErrorException>(() => repository.Post(mockAuthCreds.Object, checkin));
// repository.FailFast = false;
// repository.Post(mockAuthCreds.Object, checkin);
// request.Verify(a => a.AddParameter("access_token", "PostaccessToken"));

mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
{
{"access_token", "PostAsyncaccessToken"}
}));
repository.PostAsync(mockAuthCreds.Object, checkin).Wait();
request.Verify(a => a.AddParameter("access_token", "PostAsyncaccessToken"));
// mockAuthCreds.Setup(a => a.AuthenticationData).Returns(new ReadOnlyDictionary<string, string>(new Dictionary<string, string>()
// {
// {"access_token", "PostAsyncaccessToken"}
// }));
// repository.PostAsync(mockAuthCreds.Object, checkin).Wait();
// request.Verify(a => a.AddParameter("access_token", "PostAsyncaccessToken"));
}

[Test]
public void ConfirmBasicConstructorWorks()
{
var constructorTest = new Repository();
Assert.IsTrue(constructorTest.Client != null);
Assert.IsTrue(constructorTest.Request != null);
// var constructorTest = new Repository();
// Assert.IsTrue(constructorTest.Client != null);
// Assert.IsTrue(constructorTest.Request != null);
}

[Test]
public void TimeoutShouldGetPassedIn()
{
var timeout = 100;
var repo = new Repository(timeout: timeout);
Assert.AreEqual(repo.Request.Timeout, timeout);
// var timeout = 100;
// var repo = new Repository(timeout: timeout);
// Assert.AreEqual(repo.Request.Timeout, timeout);
}

[Test]
public void ConfirmConfigureGetRequestClearsParams()
{
var constructorTest = new Repository();
constructorTest.Request.Parameters.Add(new Parameter { Name = "param" });
Assert.IsTrue(constructorTest.Request.Parameters.Count > 0);
constructorTest.ConfigureRequest("endpoint");
Assert.IsTrue(constructorTest.Request.Parameters.Count == 0);
// var constructorTest = new Repository();
// constructorTest.Request.Parameters.Add(new Parameter { Name = "param" });
// Assert.IsTrue(constructorTest.Request.Parameters.Count > 0);
// constructorTest.ConfigureRequest("endpoint");
// Assert.IsTrue(constructorTest.Request.Parameters.Count == 0);
}
}
}