-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Milestone
Description
Problem
The run profile Partition field exists in the model and UI but is not actually consumed by any connector during import/export operations. This was discovered when integration tests (which create run profiles without specifying a partition) worked perfectly for LDAP connectors that support partitions.
Current Behaviour
- The LDAP connector (and likely all connectors) ignores the run profile's partition entirely
- Instead, imports iterate over
_connectedSystem.Partitions.Where(p => p.Selected)— using the connected system's selected partitions - The API and application layer do not validate that a partition is specified for connectors that support partitions
- The UI shows a partition selector and marks it as required, but the selected value has no effect at runtime
Required Changes
- API validation: The API should enforce a partition selection when creating run profiles for connectors that support partitions
- Connector behaviour: Connectors that support partitions should use the run profile's partition to determine what partition to perform connected system operations against, rather than using the current
_connectedSystem.Partitions.Where(p => p.Selected)approach - Integration tests: All integration test scenarios that create run profiles will need updating to specify a partition (e.g. Scenario 2, Scenario 8, and any others using
New-JIMRunProfilefor partition-supporting connectors)
Affected Files
src/JIM.Application/Servers/ConnectedSystemServer.cs—IsRunProfileValid()needs partition validationsrc/JIM.Connectors/LDAP/LdapConnectorImport.cs— uses_connectedSystem.Partitions.Where(p => p.Selected)instead ofrunProfile.Partitionsrc/JIM.Models/Interfaces/IConnectorImportUsingCalls.cs— run profile is already passed toImportAsync()src/JIM.Web/Controllers/Api/— API endpoint validationtest/integration/Setup-Scenario2.ps1— run profile creationtest/integration/Setup-Scenario8.ps1— run profile creation
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request